Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List applying EventPolicies in Brokers status #4054

Merged
merged 2 commits into from
Aug 13, 2024
Merged

List applying EventPolicies in Brokers status #4054

merged 2 commits into from
Aug 13, 2024

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Aug 12, 2024

Fixes #4037

Proposed Changes

  • 🎁 List EventPolicies in the Brokers .status.policies, which apply for it

Release Note

List applying EventPolicies in Brokers status

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/control-plane labels Aug 12, 2024
@knative-prow knative-prow bot requested review from aliok and pierDipi August 12, 2024 12:08
@creydr creydr force-pushed the broker-list-eventpolicies branch from 32d4331 to f08f9a6 Compare August 12, 2024 12:14
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 48.45%. Comparing base (b1fc8e9) to head (4bebbeb).
Report is 1 commits behind head on main.

Files Patch % Lines
...ane/pkg/reconciler/broker/namespaced_controller.go 0.00% 4 Missing ⚠️
control-plane/pkg/reconciler/broker/broker.go 33.33% 1 Missing and 1 partial ⚠️
control-plane/pkg/reconciler/testing/listers.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4054      +/-   ##
==========================================
+ Coverage   48.44%   48.45%   +0.01%     
==========================================
  Files         244      244              
  Lines       14500    14542      +42     
==========================================
+ Hits         7024     7047      +23     
- Misses       6769     6784      +15     
- Partials      707      711       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cali0707
Cali0707 reviewed Aug 12, 2024
View reviewed changes
control-plane/pkg/reconciler/base/receiver_condition_set.go
@@ -51,6 +52,7 @@ var IngressConditionSet = apis.NewLivingConditionSet(
ConditionConfigMapUpdated,
ConditionConfigParsed,
ConditionProbeSucceeded,
ConditionEventPoliciesReady,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that since this condition set is used by all components that receive events, we will need to set this condition to some form of "ready" value in the kafka sink and kafka channel reconciler code so that the tests can deploy properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I updated it for KafkaSink. KafkaChannel seems to set its own ConditionSet (which we then need to update, when we add the support in the KafkaChannel):

eventing-kafka-broker/control-plane/pkg/reconciler/channel/controller.go

Line 67 in 073bcd2

messagingv1beta.RegisterAlternateKafkaChannelConditionSet(conditionSet)

@creydr
Copy link
Contributor Author

creydr commented Aug 13, 2024

/test upgrade-tests

1 similar comment
@creydr
Copy link
Contributor Author

creydr commented Aug 13, 2024

/test upgrade-tests

@creydr
Copy link
Contributor Author

creydr commented Aug 13, 2024 

 Message:MountVolume.SetUp failed for volume "kube-api-access-b9tg9" : [failed to fetch token: serviceaccounts "default" is forbidden: User "system:node:gke-kt2-319d8247-195b-4c-default-pool-fb5a2942-8tpj" cannot create resource "serviceaccounts/token" in API group "" in the namespace "eventing-e2e13": no relationship found between node 'gke-kt2-319d8247-195b-4c-default-pool-fb5a2942-8tpj' and this object, failed to sync configmap cache: timed out waiting for the condition

/retest

@creydr creydr requested a review from Cali0707 August 13, 2024 09:36
@creydr
Copy link
Contributor Author

creydr commented Aug 13, 2024

@Cali0707 can you recheck?

Cali0707
Cali0707 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ffb67fd into knative-extensions:main Aug 13, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@aliok aliok Awaiting requested review from aliok

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[control-plane] List applying policies in Brokers .status.policies
2 participants
@creydr @Cali0707