Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List applying policies in KafkaChannel #4089

Merged
merged 7 commits into from
Sep 2, 2024
Merged

List applying policies in KafkaChannel #4089

merged 7 commits into from
Sep 2, 2024

Conversation

rahulii
Copy link
Contributor

@rahulii rahulii commented Sep 2, 2024 •
edited
Loading

Fixes #4038

Proposed Changes

  • 🎁 List applying EventPolicies in KafkaChannel

Release Note

List applying EventPolicies in KafkaChannel

Docs

@rahulii
list applying policies in kafka channel
5b8a475 
Signed-off-by: rahulii <r.sawra@gmail.com>
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2024
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/control-plane needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 2, 2024

Hi @rahulii. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rahulii
watch eventpolicies for kafkachannel controller
688d6fc 
Signed-off-by: rahulii <r.sawra@gmail.com>
@rahulii
update kafka channel status
b23f18c 
Signed-off-by: rahulii <r.sawra@gmail.com>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 2, 2024
@rahulii
add testing helper funcs for eventpolicies for kafkachannel
42ffe9d 
Signed-off-by: rahulii <r.sawra@gmail.com>
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2024
@rahulii
add unit tests
209eeb0 
Signed-off-by: rahulii <r.sawra@gmail.com>
@rahulii rahulii marked this pull request as ready for review September 2, 2024 07:21
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2024
@knative-prow knative-prow bot requested a review from Cali0707 September 2, 2024 07:21
@rahulii rahulii changed the title List applying policies in kafka channel List applying policies in KafkaChannel Sep 2, 2024
@rahulii
Copy link
Contributor Author

rahulii commented Sep 2, 2024

/cc @creydr

@knative-prow knative-prow bot requested a review from creydr September 2, 2024 07:22
creydr
creydr suggested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

control-plane/pkg/contract/contract.pb.go Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 2, 2024
@knative-prow knative-prow bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 2, 2024
@rahulii
minor fix
8a6a575 
Signed-off-by: rahulii <r.sawra@gmail.com>
@rahulii
fix review comments from creydr
d20b965 
Signed-off-by: rahulii <r.sawra@gmail.com>
@creydr
Copy link
Contributor

creydr commented Sep 2, 2024

Wondering, why we don't see the GH action runs? 🤔

/retest

creydr
creydr approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this @rahulii

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, rahulii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@knative-prow knative-prow bot merged commit ea0f055 into knative-extensions:main Sep 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[control-plane] List applying policies in KafkaChannels .status.policies
2 participants
@rahulii @creydr