Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

[release-0.22] Only return true in probe verifier if all partitions found #554

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #551

- 🐛 Fix a bug in the consolidated KafkaChannel where some Subscriptions can stay stuck in a `SubscriptionNotMarkedReadyByChannel` state for a long while.

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@knative-prow-robot knative-prow-robot requested review from a team as code owners April 20, 2021 06:15
@knative-prow-robot knative-prow-robot requested a review from a user April 20, 2021 06:15
@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 20, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 20, 2021
@google-cla
Copy link

google-cla bot commented Apr 20, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Apr 20, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/channel/consolidated/reconciler/controller/kafkachannel.go 55.2% 55.3% 0.1

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-0.22@133ad85). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-0.22     #554   +/-   ##
===============================================
  Coverage                ?   73.79%           
===============================================
  Files                   ?      147           
  Lines                   ?     5759           
  Branches                ?        0           
===============================================
  Hits                    ?     4250           
  Misses                  ?     1267           
  Partials                ?      242           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133ad85...7d537a9. Read the comment docs.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2021
@devguyio
Copy link
Contributor

@googlebot I consent

@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Apr 20, 2021
@devguyio
Copy link
Contributor

/retest

@knative-prow-robot knative-prow-robot merged commit b05b863 into knative-extensions:release-0.22 Apr 20, 2021
matzew pushed a commit to matzew/eventing-kafka that referenced this pull request Jun 21, 2021
…xtensions#554)

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>
openshift-merge-robot referenced this pull request in openshift-knative/eventing-kafka Jun 22, 2021
* Only return true in probe verifier if all partitions found (#554)

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>

* Fix a bad log line (#559)

Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants