-
Notifications
You must be signed in to change notification settings - Fork 83
[release-0.22] Only return true in probe verifier if all partitions found #554
[release-0.22] Only return true in probe verifier if all partitions found #554
Conversation
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## release-0.22 #554 +/- ##
===============================================
Coverage ? 73.79%
===============================================
Files ? 147
Lines ? 5759
Branches ? 0
===============================================
Hits ? 4250
Misses ? 1267
Partials ? 242 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@googlebot I consent |
/retest |
…xtensions#554) Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>
* Only return true in probe verifier if all partitions found (#554) Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com> * Fix a bad log line (#559) Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>
This is an automated cherry-pick of #551