Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated nats-streaming dispatcher #613

Conversation

astelmashenko
Copy link
Member

Release Note

Removes deprecated nats-streaming dispatcher and it's resources.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@knative-prow knative-prow bot requested review from Cali0707 and upodroid October 22, 2024 09:42
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.53%. Comparing base (c76507b) to head (4add2ca).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   41.12%   35.53%   -5.60%     
==========================================
  Files          62       45      -17     
  Lines        3664     2721     -943     
==========================================
- Hits         1507      967     -540     
+ Misses       2072     1689     -383     
+ Partials       85       65      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astelmashenko astelmashenko marked this pull request as ready for review October 22, 2024 10:48
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@knative-prow knative-prow bot requested a review from cardil October 22, 2024 10:48
@dsimansk
Copy link
Contributor

/override codecov/project

Copy link

knative-prow bot commented Oct 22, 2024

@dsimansk: Overrode contexts on behalf of dsimansk: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
Copy link

knative-prow bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astelmashenko, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [astelmashenko,dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 4630019 into knative-extensions:main Oct 22, 2024
20 of 22 checks passed
@astelmashenko astelmashenko deleted the feature/main/remove-deprecated-nats-streaming branch October 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants