Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.7] Upgrade to latest dependencies #994

Closed
wants to merge 1 commit into from
Closed

[release-1.7] Upgrade to latest dependencies #994

wants to merge 1 commit into from

Conversation

knative-automation
Copy link
Contributor

Cherry-pick knative-extensions/control-protocol#254 to reduce informer cache usage -evankanderson

/cc knative-sandbox/serving-writers
/assign knative-sandbox/serving-writers

Produced by: knative-sandbox/knobots/actions/update-deps

@knative-automation
upgrade to latest dependencies
34207b1 
bumping knative.dev/networking e51df7c...5f25a81:
  > 5f25a81 [release-1.7] Cherry picks (# 743)
bumping knative.dev/control-protocol f18dbde...03449ed:
  > 03449ed [release-1.7] Certificate controller to only watch secrets with a label (# 254)
bumping knative.dev/pkg 4a03844...9d7bd23:
  > 9d7bd23 [release-1.7] Fix nil pointer deref in drain when it's reset (# 2652)
  > 5f92031 [release-1.7] gofmt with go1.19 (# 2650)
  > 3b65316 [release-1.7] Function AllowRestrictedPodSecurityStandard for modifying test pods (# 2636)

Signed-off-by: Knative Automation <automation@knative.team>
@knative-prow knative-prow bot requested a review from a team February 13, 2023 21:58
@knative-prow
Copy link

knative-prow bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign nak3 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #994 (34207b1) into release-1.7 (d6f4703) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.7     #994   +/-   ##
============================================
  Coverage        80.77%   80.77%           
============================================
  Files               18       18           
  Lines             1233     1233           
============================================
  Hits               996      996           
  Misses             190      190           
  Partials            47       47

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nak3
Copy link
Contributor

nak3 commented Feb 15, 2023

The control-protocol is used for the constant variable in this repo so the change has no effect.
As other projects also closed like knative-extensions/net-contour#868 we will close this.

FYI: @ReToCode @skonto
Please re-open this if you have any objections.

@nak3 nak3 closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-automation @nak3