Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PVC support to volume mounts #1693

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Jun 24, 2022

Description

Added support for mounting PVC volume type to a service

Changes

  • Added handling for pvc volume type
  • Added unit tests
  • Added e2e tests for emptyDir and pvc types

Reference

Fixes #1633

Release Note

Add support to mount PersistentVolumeClaims

Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasgun: 0 warnings.

In response to this:

Description

Added support for mounting PVC volume type to a service

Changes

  • Added parsing for pvc volume type

Reference

Fixes #1633

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #1693 (f8ad5cb) into main (b696546) will increase coverage by 0.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main    #1693      +/-   ##
==========================================
+ Coverage   79.69%   79.71%   +0.01%     
==========================================
  Files         173      173              
  Lines       13264    13277      +13     
==========================================
+ Hits        10571    10584      +13     
  Misses       1963     1963              
  Partials      730      730              
Impacted Files Coverage Δ
pkg/kn/flags/podspec_helper.go 82.25% <92.85%> (+0.37%) ⬆️
pkg/kn/flags/podspec.go 77.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b696546...f8ad5cb. Read the comment docs.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2022
@vyasgun vyasgun force-pushed the pr/volume-types-pvc branch 9 times, most recently from 9bd777b to cf8b5b6 Compare June 27, 2022 19:34
@dsimansk
Copy link
Contributor

dsimansk commented Jul 1, 2022

Thanks!

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022
@knative-prow knative-prow bot merged commit c23a1f7 into knative:main Jul 1, 2022
@dsimansk
Copy link
Contributor

/kind feature

@knative-prow knative-prow bot added the kind/feature New feature or request label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature New feature or request lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for different volume types
2 participants