-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release script version calculation #1737
Conversation
Codecov ReportBase: 79.90% // Head: 79.90% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
=======================================
Coverage 79.90% 79.90%
=======================================
Files 174 174
Lines 13538 13538
=======================================
Hits 10817 10817
Misses 1982 1982
Partials 739 739 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.7 |
@dsimansk: new pull request created: #1741 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
This should fix display version for release. IMO the
build_flags.sh
script was sourced too soon, before release values (especially${TAG}
) were properly populated./cc @rhuss
Changes
Reference
Fixes #
Release Note
/kind bug