Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release script version calculation #1737

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Sep 21, 2022

Description

This should fix display version for release. IMO the build_flags.sh script was sourced too soon, before release values (especially ${TAG}) were properly populated.

/cc @rhuss

Changes

  • Fix release script version calculation

Reference

Fixes #

Release Note

Fix release script version calculation

/kind bug

@knative-prow knative-prow bot requested a review from rhuss September 21, 2022 15:02
@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 79.90% // Head: 79.90% // No change to project coverage 👍

Coverage data is based on head (8dd6251) compared to base (9bbef97).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1737   +/-   ##
=======================================
  Coverage   79.90%   79.90%           
=======================================
  Files         174      174           
  Lines       13538    13538           
=======================================
  Hits        10817    10817           
  Misses       1982     1982           
  Partials      739      739           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 58f686b into knative:main Sep 21, 2022
@dsimansk
Copy link
Contributor Author

dsimansk commented Oct 5, 2022

/cherry-pick release-1.7

@knative-prow-robot
Copy link
Contributor

@dsimansk: new pull request created: #1741

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants