[release-1.7] Upgrade to latest dependencies

go.mod

@@ -21,11 +21,11 @@ require (
 	k8s.io/cli-runtime v0.23.4
 	k8s.io/client-go v0.23.9
 	k8s.io/code-generator v0.23.9
-	knative.dev/eventing v0.34.1
+	knative.dev/eventing v0.34.7
 	knative.dev/hack v0.0.0-20220823140917-8d1e4ccf9dc3
-	knative.dev/networking v0.0.0-20220818010248-e51df7cdf571
-	knative.dev/pkg v0.0.0-20220818004048-4a03844c0b15
-	knative.dev/serving v0.34.0
+	knative.dev/networking v0.0.0-20221208211516-5f25a81cd43e
+	knative.dev/pkg v0.0.0-20221123011941-9d7bd235ceed
+	knative.dev/serving v0.34.4
 	sigs.k8s.io/yaml v1.3.0
 )
 

go.sum

@@ -1318,16 +1318,16 @@ k8s.io/utils v0.0.0-20210802155522-efc7438f0176/go.mod h1:jPW/WVKK9YHAvNhRxK0md/
 k8s.io/utils v0.0.0-20211116205334-6203023598ed/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA=
 k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9 h1:HNSDgDCrr/6Ly3WEGKZftiE7IY19Vz2GdbOCyI4qqhc=
 k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA=
-knative.dev/eventing v0.34.1 h1:r6QuQmDCmmSANdTRLdbKb6YcYaJoeNpEuFfS8Bq0ZgQ=
-knative.dev/eventing v0.34.1/go.mod h1:6UnNnPrEUNAM9PfCpf7L8N7G/1vq+HQlpOjzndY6ryw=
+knative.dev/eventing v0.34.7 h1:P2YmnDBxpqQatVTZRVHftPv3wuO/+GN83kCXQVgtM20=
+knative.dev/eventing v0.34.7/go.mod h1:6UnNnPrEUNAM9PfCpf7L8N7G/1vq+HQlpOjzndY6ryw=
 knative.dev/hack v0.0.0-20220823140917-8d1e4ccf9dc3 h1:umaeMRecA0g5g48L9tnEAkTBIitr9eKWMyJYo9YttAA=
 knative.dev/hack v0.0.0-20220823140917-8d1e4ccf9dc3/go.mod h1:t/azP8I/Cygaw+87O7rkAPrNRjCelmtfSzWzu/9TM7I=
-knative.dev/networking v0.0.0-20220818010248-e51df7cdf571 h1:Lu/TsJjxg1p+2CMr2LNHEdEFBNHYjDoZv2f1QZoM8jg=
-knative.dev/networking v0.0.0-20220818010248-e51df7cdf571/go.mod h1:m3ataWRwmbHjOY9sCFvcDWRNLVITxVl0fH0RxdCa4jE=
-knative.dev/pkg v0.0.0-20220818004048-4a03844c0b15 h1:GNmzHVaUo3zoi/wtIN71LPQaWy6DdoYzmb+GIq2s4fw=
-knative.dev/pkg v0.0.0-20220818004048-4a03844c0b15/go.mod h1:YLjXbkQLlGHok+u0FLfMbBHFzY9WGu3GHhnrptoAy8I=
-knative.dev/serving v0.34.0 h1:x3fS4e0AcNBBlQv5Dd5y30W2gtrxndUEwIEPknZfeVg=
-knative.dev/serving v0.34.0/go.mod h1:IyfedOBq3KzcD5dZONjbix2BfS0jOwDq5td8UE9CjCk=
+knative.dev/networking v0.0.0-20221208211516-5f25a81cd43e h1:Ys3mJ0wYF+1OvdevtqACQX+HiHpZU4kVEE33/rNNzmI=
+knative.dev/networking v0.0.0-20221208211516-5f25a81cd43e/go.mod h1:m3ataWRwmbHjOY9sCFvcDWRNLVITxVl0fH0RxdCa4jE=
+knative.dev/pkg v0.0.0-20221123011941-9d7bd235ceed h1:Xk4DRdbRdI7Ky8vOGQK4S3nUHTRRpTjRMsK+9Zif94s=
+knative.dev/pkg v0.0.0-20221123011941-9d7bd235ceed/go.mod h1:M+Amt1YZl5Nkl6+5FDFVIPaivsk2o5K/cIzOVq6Nsg0=
+knative.dev/serving v0.34.4 h1:3K9uVi2w6i7YmVbWIVC8qvMhn9l+3uTAOMywmjV8WXY=
+knative.dev/serving v0.34.4/go.mod h1:FXpXkiRvUJQM4zBgujcLi+oqtwqcBu3WduFdNIB0HrE=
 rsc.io/binaryregexp v0.2.0/go.mod h1:qTv7/COck+e2FymRvadv62gMdZztPaShugOCi3I+8D8=
 rsc.io/quote/v3 v3.1.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=
 rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=

lib/test/channel.go

@@ -54,7 +54,7 @@ func ChannelDelete(r *KnRunResultCollector, cname string) {
 	assert.Check(r.T(), util.ContainsAllIgnoreCase(out.Stdout, "channel", cname, "deleted"))
 }
 
-//ChannelListTypes return available channel types
+// ChannelListTypes return available channel types
 func ChannelListTypes(r *KnRunResultCollector, args ...string) string {
 	cmd := []string{"channel", "list-types"}
 	cmd = append(cmd, args...)

pkg/errors/factory.go

@@ -61,8 +61,8 @@ func newStatusError(err error) error {
 	return err
 }
 
-//Retrieves a custom error struct based on the original error APIStatus struct
-//Returns the original error struct in case it can't identify the kind of APIStatus error
+// Retrieves a custom error struct based on the original error APIStatus struct
+// Returns the original error struct in case it can't identify the kind of APIStatus error
 func GetError(err error) error {
 	if err == nil {
 		return nil

pkg/eventing/v1/client.go

@@ -86,7 +86,7 @@ func NewKnEventingClient(client clientv1.EventingV1Interface, namespace string)
 	}
 }
 
-//CreateTrigger is used to create an instance of trigger
+// CreateTrigger is used to create an instance of trigger
 func (c *knEventingClient) CreateTrigger(ctx context.Context, trigger *eventingv1.Trigger) error {
 	_, err := c.client.Triggers(c.namespace).Create(ctx, trigger, meta_v1.CreateOptions{})
 	if err != nil {
@@ -95,7 +95,7 @@ func (c *knEventingClient) CreateTrigger(ctx context.Context, trigger *eventingv
 	return nil
 }
 
-//DeleteTrigger is used to delete an instance of trigger
+// DeleteTrigger is used to delete an instance of trigger
 func (c *knEventingClient) DeleteTrigger(ctx context.Context, name string) error {
 	err := c.client.Triggers(c.namespace).Delete(ctx, name, apis_v1.DeleteOptions{})
 	if err != nil {
@@ -104,7 +104,7 @@ func (c *knEventingClient) DeleteTrigger(ctx context.Context, name string) error
 	return nil
 }
 
-//GetTrigger is used to get an instance of trigger
+// GetTrigger is used to get an instance of trigger
 func (c *knEventingClient) GetTrigger(ctx context.Context, name string) (*eventingv1.Trigger, error) {
 	trigger, err := c.client.Triggers(c.namespace).Get(ctx, name, apis_v1.GetOptions{})
 	if err != nil {

pkg/kn/commands/broker/broker_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/kn/commands/revision/delete_mock_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

pkg/kn/commands/service/update_test.go

@@ -981,7 +981,7 @@ func TestServiceUpdateNoClusterLocal(t *testing.T) {
 	assert.DeepEqual(t, expected, actual)
 }
 
-//TODO: add check for template name not changing when issue #646 solution is merged
+// TODO: add check for template name not changing when issue #646 solution is merged
 func TestServiceUpdateNoClusterLocalOnPublicService(t *testing.T) {
 	original := newEmptyService()
 	original.ObjectMeta.Labels = map[string]string{}
@@ -1000,7 +1000,7 @@ func TestServiceUpdateNoClusterLocalOnPublicService(t *testing.T) {
 	assert.DeepEqual(t, expected, actual)
 }
 
-//TODO: add check for template name not changing when issue #646 solution is merged
+// TODO: add check for template name not changing when issue #646 solution is merged
 func TestServiceUpdateNoClusterLocalOnPrivateService(t *testing.T) {
 	original := newEmptyService()
 	original.ObjectMeta.Labels = map[string]string{network.VisibilityLabelKey: serving.VisibilityClusterLocal}

pkg/kn/commands/source/apiserver/flags.go

@@ -123,7 +123,7 @@ func constructAPIVersionKindSelector(s []string) ([]sourcesv1.APIVersionKindSele
 	return array, nil
 }
 
-//getValidAPIVersionKindSelector is to parse resource spec from a string
+// getValidAPIVersionKindSelector is to parse resource spec from a string
 func getValidAPIVersionKindSelector(resource string) (*sourcesv1.APIVersionKindSelector, error) {
 	var err error
 
@@ -145,7 +145,7 @@ func getValidAPIVersionKindSelector(resource string) (*sourcesv1.APIVersionKindS
 	return &sourcesv1.APIVersionKindSelector{Kind: kind, APIVersion: version, LabelSelector: labelSelector}, nil
 }
 
-//Add is to set parameters
+// Add is to set parameters
 func (f *APIServerSourceUpdateFlags) Add(cmd *cobra.Command) {
 	cmd.Flags().StringVar(&f.ServiceAccountName,
 		"service-account",

pkg/kn/commands/source/ping/update_test.go

@@ -68,7 +68,7 @@ func TestSimplePingUpdate(t *testing.T) {
 	pingRecorder.Validate()
 }
 
-//TestSimplePingUpdateCEOverrides updates ce override, schedule, data and sink
+// TestSimplePingUpdateCEOverrides updates ce override, schedule, data and sink
 func TestSimplePingUpdateCEOverrides(t *testing.T) {
 	pingSourceClient := sourcesv1beta2.NewMockKnPingSourceClient(t)
 	pingRecorder := pingSourceClient.Recorder()

pkg/kn/commands/trigger/update_flags.go

@@ -48,7 +48,7 @@ func (f *TriggerUpdateFlags) GetUpdateFilters() (map[string]string, []string, er
 	return filters, removes, nil
 }
 
-//Add is to set parameters
+// Add is to set parameters
 func (f *TriggerUpdateFlags) Add(cmd *cobra.Command) {
 	cmd.Flags().StringVar(&f.Broker, "broker", "default", "Name of the Broker which the trigger associates with.")
 	// The Sugar controller was integrated into main Eventing controller. With that the default behavior was changed as well.

pkg/kn/config/testing_test.go

@@ -21,7 +21,6 @@ import (
 )
 
 // Test to keep code coverage quality gate happy.
-//
 func TestTestConfig(t *testing.T) {
 	cfg := TestConfig{
 		TestPluginsDir:          "pluginsDir",

pkg/kn/flags/podspec.go

@@ -78,7 +78,7 @@ func (s *uniqueStringArg) Type() string {
 
 func (s *uniqueStringArg) String() string { return string(*s) }
 
-//AddUpdateFlags will add PodSpec flags related to environment variable to FlagSet of update command
+// AddUpdateFlags will add PodSpec flags related to environment variable to FlagSet of update command
 func (p *PodSpecFlags) AddUpdateFlags(flagset *pflag.FlagSet) []string {
 	flagNames := []string{}
 	flagset.StringArrayVarP(&p.Env, "env", "e", []string{},
@@ -104,7 +104,7 @@ func (p *PodSpecFlags) AddUpdateFlags(flagset *pflag.FlagSet) []string {
 	return flagNames
 }
 
-//AddCreateFlags will add PodSpec flags related to environment variable to FlagSet of create command
+// AddCreateFlags will add PodSpec flags related to environment variable to FlagSet of create command
 func (p *PodSpecFlags) AddCreateFlags(flagset *pflag.FlagSet) []string {
 	flagNames := []string{}
 	flagset.StringArrayVarP(&p.Env, "env", "e", []string{},
@@ -127,7 +127,7 @@ func (p *PodSpecFlags) AddCreateFlags(flagset *pflag.FlagSet) []string {
 	return flagNames
 }
 
-//AddFlags will add PodSpec related flags to FlagSet
+// AddFlags will add PodSpec related flags to FlagSet
 func (p *PodSpecFlags) AddFlags(flagset *pflag.FlagSet) []string {
 
 	flagNames := []string{}

pkg/printers/tablegenerator.go

@@ -124,7 +124,9 @@ func (h *HumanReadablePrinter) TableHandler(columnDefinitions []metav1beta1.Tabl
 // ValidateRowPrintHandlerFunc validates print handler signature.
 // printFunc is the function that will be called to print an object.
 // It must be of the following type:
-//  func printFunc(object ObjectType, options PrintOptions) ([]metav1beta1.TableRow, error)
+//
+//	func printFunc(object ObjectType, options PrintOptions) ([]metav1beta1.TableRow, error)
+//
 // where ObjectType is the type of the object that will be printed, and the first
 // return value is an array of rows, with each row containing a number of cells that
 // match the number of columns defined for that printer function.

pkg/sources/v1/apiserver_client.go

@@ -68,7 +68,7 @@ func newKnAPIServerSourcesClient(client clientv1.ApiServerSourceInterface, names
 	}
 }
 
-//GetAPIServerSource returns apiSource object if present
+// GetAPIServerSource returns apiSource object if present
 func (c *apiServerSourcesClient) GetAPIServerSource(ctx context.Context, name string) (*v1.ApiServerSource, error) {
 	apiSource, err := c.client.Get(ctx, name, metav1.GetOptions{})
 	if err != nil {
@@ -81,7 +81,7 @@ func (c *apiServerSourcesClient) GetAPIServerSource(ctx context.Context, name st
 	return apiSource, nil
 }
 
-//CreateAPIServerSource is used to create an instance of ApiServerSource
+// CreateAPIServerSource is used to create an instance of ApiServerSource
 func (c *apiServerSourcesClient) CreateAPIServerSource(ctx context.Context, apiSource *v1.ApiServerSource) error {
 	_, err := c.client.Create(ctx, apiSource, metav1.CreateOptions{})
 	if err != nil {
@@ -91,7 +91,7 @@ func (c *apiServerSourcesClient) CreateAPIServerSource(ctx context.Context, apiS
 	return nil
 }
 
-//UpdateAPIServerSource is used to update an instance of ApiServerSource
+// UpdateAPIServerSource is used to update an instance of ApiServerSource
 func (c *apiServerSourcesClient) UpdateAPIServerSource(ctx context.Context, apiSource *v1.ApiServerSource) error {
 	_, err := c.client.Update(ctx, apiSource, metav1.UpdateOptions{})
 	if err != nil {
@@ -101,7 +101,7 @@ func (c *apiServerSourcesClient) UpdateAPIServerSource(ctx context.Context, apiS
 	return nil
 }
 
-//DeleteAPIServerSource is used to create an instance of ApiServerSource
+// DeleteAPIServerSource is used to create an instance of ApiServerSource
 func (c *apiServerSourcesClient) DeleteAPIServerSource(ctx context.Context, name string) error {
 	err := c.client.Delete(ctx, name, metav1.DeleteOptions{})
 	if err != nil {

pkg/sources/v1/binding_client.go

@@ -65,7 +65,7 @@ func newKnSinkBindingClient(client clientv1.SinkBindingInterface, namespace stri
 	}
 }
 
-//CreateSinkBinding is used to create an instance of binding
+// CreateSinkBinding is used to create an instance of binding
 func (c *knBindingClient) CreateSinkBinding(ctx context.Context, binding *v1.SinkBinding) error {
 	_, err := c.client.Create(ctx, binding, metav1.CreateOptions{})
 	if err != nil {
@@ -74,7 +74,7 @@ func (c *knBindingClient) CreateSinkBinding(ctx context.Context, binding *v1.Sin
 	return nil
 }
 
-//DeleteSinkBinding is used to delete an instance of binding
+// DeleteSinkBinding is used to delete an instance of binding
 func (c *knBindingClient) DeleteSinkBinding(ctx context.Context, name string) error {
 	err := c.client.Delete(ctx, name, apisv1.DeleteOptions{})
 	if err != nil {
@@ -83,7 +83,7 @@ func (c *knBindingClient) DeleteSinkBinding(ctx context.Context, name string) er
 	return nil
 }
 
-//GetSinkBinding is used to get an instance of binding
+// GetSinkBinding is used to get an instance of binding
 func (c *knBindingClient) GetSinkBinding(ctx context.Context, name string) (*v1.SinkBinding, error) {
 	binding, err := c.client.Get(ctx, name, apisv1.GetOptions{})
 	if err != nil {
@@ -119,7 +119,7 @@ func (c *knBindingClient) ListSinkBindings(ctx context.Context) (*v1.SinkBinding
 	return bindingListNew, nil
 }
 
-//CreateSinkBinding is used to create an instance of binding
+// CreateSinkBinding is used to create an instance of binding
 func (c *knBindingClient) UpdateSinkBinding(ctx context.Context, binding *v1.SinkBinding) error {
 	_, err := c.client.Update(ctx, binding, metav1.UpdateOptions{})
 	if err != nil {

pkg/sources/v1/container_client.go

@@ -107,7 +107,7 @@ func newKnContainerSourcesClient(client clientv1.ContainerSourceInterface, names
 	}
 }
 
-//GetContainerSource returns containerSrc object if present
+// GetContainerSource returns containerSrc object if present
 func (c *containerSourcesClient) GetContainerSource(ctx context.Context, name string) (*v1.ContainerSource, error) {
 	containerSrc, err := c.client.Get(ctx, name, metav1.GetOptions{})
 	if err != nil {
@@ -117,7 +117,7 @@ func (c *containerSourcesClient) GetContainerSource(ctx context.Context, name st
 	return containerSrc, nil
 }
 
-//CreateContainerSource is used to create an instance of ContainerSource
+// CreateContainerSource is used to create an instance of ContainerSource
 func (c *containerSourcesClient) CreateContainerSource(ctx context.Context, containerSrc *v1.ContainerSource) error {
 	_, err := c.client.Create(ctx, containerSrc, metav1.CreateOptions{})
 	if err != nil {
@@ -127,7 +127,7 @@ func (c *containerSourcesClient) CreateContainerSource(ctx context.Context, cont
 	return nil
 }
 
-//UpdateContainerSource is used to update an instance of ContainerSource
+// UpdateContainerSource is used to update an instance of ContainerSource
 func (c *containerSourcesClient) UpdateContainerSource(ctx context.Context, containerSrc *v1.ContainerSource) error {
 	_, err := c.client.Update(ctx, containerSrc, metav1.UpdateOptions{})
 	if err != nil {
@@ -137,7 +137,7 @@ func (c *containerSourcesClient) UpdateContainerSource(ctx context.Context, cont
 	return nil
 }
 
-//DeleteContainerSource is used to create an instance of ContainerSource
+// DeleteContainerSource is used to create an instance of ContainerSource
 func (c *containerSourcesClient) DeleteContainerSource(name string, ctx context.Context) error {
 	return c.client.Delete(ctx, name, metav1.DeleteOptions{})
 }

vendor/knative.dev/eventing/pkg/apis/eventing/v1/trigger_types.go

@@ -177,7 +177,7 @@ type SubscriptionsAPIFilter struct {
 
 // TriggerFilterAttributes is a map of context attribute names to values for
 // filtering by equality. Only exact matches will pass the filter. You can use
-// the value '' to indicate all strings match.
+// the value ” to indicate all strings match.
 type TriggerFilterAttributes map[string]string
 
 // TriggerStatus represents the current state of a Trigger.