Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default SecurityContext to none #1832

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

dsimansk
Copy link
Contributor

Description

Don't force strict security profile just yet.

Changes

  • Change default SecurityContext value to none

Reference

Fixes #

Release Note

Change default SecurityContext value to `none`

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2023
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsimansk: 0 warnings.

In response to this:

Description

Don't force strict security profile just yet.

Changes

  • Change default SecurityContext value to none

Reference

Fixes #

Release Note

Change default SecurityContext value to `none`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@rhuss
Copy link
Contributor

rhuss commented Jul 26, 2023

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3a7d8c1) 79.66% compared to head (15cb51a) 79.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1832   +/-   ##
=======================================
  Coverage   79.66%   79.67%           
=======================================
  Files         179      179           
  Lines       13946    13938    -8     
=======================================
- Hits        11110    11105    -5     
+ Misses       2069     2067    -2     
+ Partials      767      766    -1     
Files Changed Coverage Δ
pkg/kn/flags/podspec.go 75.00% <100.00%> (+0.75%) ⬆️
pkg/kn/flags/podspec_helper.go 85.44% <100.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit 4621b10 into knative:main Jul 26, 2023
17 checks passed
@dsimansk dsimansk added the kind/feature New feature or request label Jul 26, 2023
@dsimansk dsimansk added this to the Knative 1.11 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature New feature or request lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants