Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unusable --broker flag from trigger update cmd #1847

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Aug 10, 2023

Description

Changes

  • Remove unusable --broker flag from trigger update cmd

Reference

Fixes #1813

Release Note

Remove unusable `--broker` flag from `trigger update` cmd

/cc @rhuss @vyasgun

@knative-prow knative-prow bot requested review from rhuss and vyasgun August 10, 2023 14:48
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@dsimansk dsimansk changed the title Remove unusable --inject-broker flag from trigger update cmd Remove unusable --broker flag from trigger update cmd Aug 10, 2023
@dsimansk dsimansk added the kind/bug Categorizes issue or PR as related to a bug. label Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (8dc8a9f) 79.67% compared to head (cf296dc) 79.64%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
- Coverage   79.67%   79.64%   -0.03%     
==========================================
  Files         179      179              
  Lines       13938    13938              
==========================================
- Hits        11105    11101       -4     
- Misses       2067     2070       +3     
- Partials      766      767       +1     
Files Changed Coverage Δ
pkg/kn/commands/trigger/update_flags.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9676e46 into knative:main Aug 16, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kn trigger update --help information is incorrect
2 participants