-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-update dependencies #713
Auto-update dependencies #713
Conversation
/hold Not sure what happened here, but this is clearly wrong 😅 |
@mattmoor 🎵🎵... no deps, no cry ... 🎵🎵 |
@rhuss I'll futz with it a bit today to see if I can get things sorted out between all of my meetings 😢 |
@mattmoor no rush at all, we need to get out 0.13.0 tomorrow first anyway. |
e8266b6
to
6e03c0e
Compare
That's more like it 😎 /unhold |
go.mod
Outdated
knative.dev/serving v0.13.0 | ||
knative.dev/test-infra v0.0.0-20200229011351-4dac123b9a3d | ||
knative.dev/pkg v0.0.0-20200309165928-1327ff317946 | ||
knative.dev/serving v0.13.1-0.20200309164530-f5ef18095760 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about it, I'm not sure that we continuously update on knative serving / eventing master and not stick to the latest released version, especially not in the the week between a Knative serving release and a Knative client release. For this "catch-up" week we should stick to the just-released version of Knative serving until the kn release. After that, I'm happy to switch back to a close master-branch sync.
@mattmoor what are you thoughts on this ? I mean, we really want to have kn 0.13.0
to depend on knative serving 0.13.0
(or 0.13.1 if there has been a hotfix in this week).
We could do this manually by just not merging the dep auto-updates in this 'between-releases' week, or maybe pause the bot for this week (maybe even automatically).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhuss this is exactly what we do with knative/pkg, and why I added VERSION
, so that once the release branches exist we can track those until client releases with VERSION=release-0.13
, which results in:
go get -d knative.dev/foo@release-0.13
0.13.x
all cut from release-0.13
, so this feels like what we want. Happy to discuss more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that VERSION
is the go mod
way of doing what we do by changing the branch =
in Gopkg.toml
in other repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also notable: pinning and unpinning is entirely under your control in the --upgrade
script, this is just running that daily for you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks ! yes, that makes totally sense to track the head of the release branch, if we ensure that we don't hit an intermediate state (e.g. some working state between two dot releases). Maybe it's better really to track the tags on those branches (assuming that activity on the release branch will end up in a patch release anyway soon).
Let me wrap my brain around the update, and will update the scripts accordingly
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after release
6e03c0e
to
06fc480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have an update to README for the config defaults?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, maximilien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
06fc480
to
a5c3aa3
Compare
dda9591
to
8e74bdc
Compare
8e74bdc
to
6a9bcc6
Compare
6a9bcc6
to
fed5197
Compare
Fix have to fix the compile time error first. |
fed5197
to
e39814f
Compare
Produced via: `./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh` /assign maximilien rhuss /cc maximilien rhuss
e39814f
to
03a70ca
Compare
@mattmoor: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closed in favor of #750 |
Produced via:
./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh
/assign maximilien rhuss
/cc maximilien rhuss