Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update dependencies #713

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Mar 9, 2020

Produced via:
./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh
/assign maximilien rhuss
/cc maximilien rhuss

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 9, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 9, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Mar 9, 2020

/hold

Not sure what happened here, but this is clearly wrong 😅

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020
@rhuss
Copy link
Contributor

rhuss commented Mar 9, 2020

@mattmoor 🎵🎵... no deps, no cry ... 🎵🎵

@mattmoor
Copy link
Member Author

mattmoor commented Mar 9, 2020

@rhuss I'll futz with it a bit today to see if I can get things sorted out between all of my meetings 😢

@rhuss
Copy link
Contributor

rhuss commented Mar 9, 2020

@mattmoor no rush at all, we need to get out 0.13.0 tomorrow first anyway.

@mattmoor mattmoor force-pushed the dep-update-knative-client-f9fwx-pod-m7std branch from e8266b6 to 6e03c0e Compare March 9, 2020 17:52
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 9, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Mar 9, 2020

That's more like it 😎

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020
go.mod Outdated
knative.dev/serving v0.13.0
knative.dev/test-infra v0.0.0-20200229011351-4dac123b9a3d
knative.dev/pkg v0.0.0-20200309165928-1327ff317946
knative.dev/serving v0.13.1-0.20200309164530-f5ef18095760
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, I'm not sure that we continuously update on knative serving / eventing master and not stick to the latest released version, especially not in the the week between a Knative serving release and a Knative client release. For this "catch-up" week we should stick to the just-released version of Knative serving until the kn release. After that, I'm happy to switch back to a close master-branch sync.

@mattmoor what are you thoughts on this ? I mean, we really want to have kn 0.13.0 to depend on knative serving 0.13.0 (or 0.13.1 if there has been a hotfix in this week).

We could do this manually by just not merging the dep auto-updates in this 'between-releases' week, or maybe pause the bot for this week (maybe even automatically).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhuss this is exactly what we do with knative/pkg, and why I added VERSION, so that once the release branches exist we can track those until client releases with VERSION=release-0.13, which results in:

go get -d knative.dev/foo@release-0.13

0.13.x all cut from release-0.13, so this feels like what we want. Happy to discuss more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that VERSION is the go mod way of doing what we do by changing the branch = in Gopkg.toml in other repos.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also notable: pinning and unpinning is entirely under your control in the --upgrade script, this is just running that daily for you :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks ! yes, that makes totally sense to track the head of the release branch, if we ensure that we don't hit an intermediate state (e.g. some working state between two dot releases). Maybe it's better really to track the tags on those branches (assuming that activity on the release branch will end up in a patch release anyway soon).

Let me wrap my brain around the update, and will update the scripts accordingly

@rhuss
Copy link
Contributor

rhuss commented Mar 9, 2020

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after release

@mattmoor mattmoor force-pushed the dep-update-knative-client-f9fwx-pod-m7std branch from 6e03c0e to 06fc480 Compare March 10, 2020 14:01
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have an update to README for the config defaults?

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mattmoor,maximilien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor mattmoor force-pushed the dep-update-knative-client-f9fwx-pod-m7std branch from 06fc480 to a5c3aa3 Compare March 11, 2020 14:15
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2020
@mattmoor mattmoor force-pushed the dep-update-knative-client-f9fwx-pod-m7std branch 2 times, most recently from dda9591 to 8e74bdc Compare March 13, 2020 14:17
@mattmoor mattmoor force-pushed the dep-update-knative-client-f9fwx-pod-m7std branch from 8e74bdc to 6a9bcc6 Compare March 16, 2020 14:12
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2020
@mattmoor mattmoor force-pushed the dep-update-knative-client-f9fwx-pod-m7std branch from 6a9bcc6 to fed5197 Compare March 17, 2020 14:21
@rhuss
Copy link
Contributor

rhuss commented Mar 17, 2020

Fix have to fix the compile time error first.

@mattmoor mattmoor force-pushed the dep-update-knative-client-f9fwx-pod-m7std branch from fed5197 to e39814f Compare March 18, 2020 14:15
Produced via:
  `./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh`
/assign maximilien rhuss
/cc maximilien rhuss
@mattmoor mattmoor force-pushed the dep-update-knative-client-f9fwx-pod-m7std branch from e39814f to 03a70ca Compare March 19, 2020 14:04
@knative-prow-robot
Copy link
Contributor

@mattmoor: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-client-integration-tests-latest-release 03a70ca link /test pull-knative-client-integration-tests-latest-release
pull-knative-client-integration-tests 03a70ca link /test pull-knative-client-integration-tests
pull-knative-client-unit-tests 03a70ca link /test pull-knative-client-unit-tests
pull-knative-client-build-tests 03a70ca link /test pull-knative-client-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhuss
Copy link
Contributor

rhuss commented Mar 20, 2020

Closed in favor of #750

@rhuss rhuss closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants