Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WG leads group #1577

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

aliok
Copy link
Member

@aliok aliok commented Jun 7, 2024

Changes

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Jun 7, 2024

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from cardil and upodroid June 7, 2024 10:15
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2024
Comment on lines -14 to 26
- dprotaso@gmail.com
# SC
- aliok@redhat.com
- developer@nrrso.com
- evan.k.anderson@gmail.com
- evana@vmware.com
- evankanderson@knative.team
- naina.sng@gmail.com
- salaboy@gmail.com
# TOC
- david.hadas@gmail.com
- dprotaso@gmail.com
- dsimansk@redhat.com
- d.simansky@gmail.com
- paul@paulschweigert.com
- paulschw@us.ibm.com
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work?

owners:
      - toc@knative.team
      - steering@knative.team

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't, a group can't own another group. Its a limitation of the Google Groups API

- houshengbo@knative.team
# Productivity
- cy@borg.dev
- ksuszyns@redhat.com
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cardil I wasn't able to find the email address you've used in other Knative groups. Is this the address you want to use?

@dprotaso
Copy link
Member

dprotaso commented Jul 8, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
Copy link

knative-prow bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b889161 into knative:main Jul 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants