Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: add runtimeclassnames post #6159

Merged

Conversation

BobyMCbobs
Copy link
Member

@BobyMCbobs BobyMCbobs commented Nov 15, 2024

adds a blog post for configuring Knative Serving to use RuntimeClasses

Proposed Changes

  • talk about Knative Serving config-deployment setting for RuntimeClassName

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3ed11ce
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/674cc0bde547960008cc6277
😎 Deploy Preview https://deploy-preview-6159--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for starting on this @BobyMCbobs !

Exciting to see this feature + the blog for it

- such as through Kata or gVisor
- functionality
- such as through GPU RuntimeClasses
-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it seems like you left an extra point here

Suggested change
-

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to remember what the other thing is. Good things come in threes!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, looking at the preview render doesn't display nested points unfortunately

https://deploy-preview-6159--knative.netlify.app/blog/articles/configurable-runtimeclassnames/#why-is-this-important

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely recall running into this in the past, maybe using another space or two will fix the render?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah huh! That did the trick. Cheers!


**What is a Runtime Class?**

A Runtime Class for configuring the handler that runs a container, such as `runc`, `crun`, `runsc`, `nvidia` or `kata`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe clarify what you mean by "handler" here? If someone doesn't have a background in this, I think this sentence/section would be a little confusing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know whether the current line resolve this!

blog/docs/articles/configurable-runtimeclassnames.md Outdated Show resolved Hide resolved
@BobyMCbobs BobyMCbobs force-pushed the add-blog-post-for-runtimeclassnames branch 3 times, most recently from 16644ea to 60c953e Compare November 17, 2024 02:15
@BobyMCbobs BobyMCbobs marked this pull request as ready for review November 17, 2024 02:15
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2024
@knative-prow knative-prow bot requested review from Cali0707 and ReToCode November 17, 2024 02:16
@BobyMCbobs BobyMCbobs force-pushed the add-blog-post-for-runtimeclassnames branch 3 times, most recently from d807d2e to dc0b594 Compare November 17, 2024 19:08
@BobyMCbobs
Copy link
Member Author

Ready for review!

@BobyMCbobs BobyMCbobs force-pushed the add-blog-post-for-runtimeclassnames branch from dc0b594 to 978b381 Compare November 18, 2024 21:30
@Leo6Leo
Copy link
Member

Leo6Leo commented Nov 21, 2024

/cc @mmejia02 @Leo6Leo for social media

@knative-prow knative-prow bot requested a review from Leo6Leo November 21, 2024 14:27
Copy link

knative-prow bot commented Nov 21, 2024

@Leo6Leo: GitHub didn't allow me to request PR reviews from the following users: for, social, media.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mmejia02 @Leo6Leo for social media

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested a review from mmejia02 November 21, 2024 14:27
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just a few small comments then this is good to go!


**What is a Runtime Class?**

Runtime Classes configure the runtime of a container with settings and handlers, such as `runc`, `crun`, `runsc`, `nvidia`/`nvidia-cdi` or `kata`. `runc` being the defacto which provides kernel-level isolation which is often unsuitable for running untrusted workloads.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expand a little bit on what you mean by settings and handlers here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it now. What do you think?


For Knative docs, [see here](https://knative.dev/docs/serving/configuration/deployment/#configuring-selectable-runtimeclassname).

## Why is this important?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could move this section to before the Knative serving specifics so that we motivate readers before we tell them how to change stuff?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking! I shuffled the sections

@BobyMCbobs BobyMCbobs force-pushed the add-blog-post-for-runtimeclassnames branch 2 times, most recently from 135dd48 to 526e6c0 Compare November 21, 2024 18:09
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2024
adds a blog post for configuring Knative Serving to use RuntimeClasses
@BobyMCbobs BobyMCbobs force-pushed the add-blog-post-for-runtimeclassnames branch from 526e6c0 to 3ed11ce Compare December 1, 2024 20:02
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2024
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @BobyMCbobs !

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2024
Copy link

knative-prow bot commented Dec 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BobyMCbobs, Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2024
@knative-prow knative-prow bot merged commit 010c514 into knative:main Dec 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants