-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: add runtimeclassnames post #6159
blog: add runtimeclassnames post #6159
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for starting on this @BobyMCbobs !
Exciting to see this feature + the blog for it
- such as through Kata or gVisor | ||
- functionality | ||
- such as through GPU RuntimeClasses | ||
- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it seems like you left an extra point here
- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to remember what the other thing is. Good things come in threes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, looking at the preview render doesn't display nested points unfortunately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vaguely recall running into this in the past, maybe using another space or two will fix the render?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah huh! That did the trick. Cheers!
|
||
**What is a Runtime Class?** | ||
|
||
A Runtime Class for configuring the handler that runs a container, such as `runc`, `crun`, `runsc`, `nvidia` or `kata`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe clarify what you mean by "handler" here? If someone doesn't have a background in this, I think this sentence/section would be a little confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know whether the current line resolve this!
16644ea
to
60c953e
Compare
d807d2e
to
dc0b594
Compare
Ready for review! |
dc0b594
to
978b381
Compare
@Leo6Leo: GitHub didn't allow me to request PR reviews from the following users: for, social, media. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Just a few small comments then this is good to go!
|
||
**What is a Runtime Class?** | ||
|
||
Runtime Classes configure the runtime of a container with settings and handlers, such as `runc`, `crun`, `runsc`, `nvidia`/`nvidia-cdi` or `kata`. `runc` being the defacto which provides kernel-level isolation which is often unsuitable for running untrusted workloads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you expand a little bit on what you mean by settings and handlers here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it now. What do you think?
|
||
For Knative docs, [see here](https://knative.dev/docs/serving/configuration/deployment/#configuring-selectable-runtimeclassname). | ||
|
||
## Why is this important? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could move this section to before the Knative serving specifics so that we motivate readers before we tell them how to change stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking! I shuffled the sections
135dd48
to
526e6c0
Compare
adds a blog post for configuring Knative Serving to use RuntimeClasses
526e6c0
to
3ed11ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @BobyMCbobs !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BobyMCbobs, Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adds a blog post for configuring Knative Serving to use RuntimeClasses
Proposed Changes