Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sink Index page #6165

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Update Sink Index page #6165

merged 1 commit into from
Nov 27, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 27, 2024

Proposed Changes

  • Adding new integration sink options to sink index

@matzew
Adding new sinks to sink index
c9551f5 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi November 27, 2024 13:23
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c9551f5
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/67471d4bf9622c00089b2882
😎 Deploy Preview https://deploy-preview-6165--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matzew
Copy link
Member Author

matzew commented Nov 27, 2024

@Cali0707 wanna take a look here?

Cali0707
Cali0707 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@knative-prow knative-prow bot merged commit 82343b2 into knative:main Nov 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzew @Cali0707