Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Commit

Permalink
Comment fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
tzununbekov committed May 6, 2020
1 parent 7313ac0 commit 82e0bef
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion gitlab/cmd/webhook/main.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2018 The Knative Authors
Copyright 2020 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
4 changes: 2 additions & 2 deletions gitlab/pkg/apis/bindings/v1alpha1/gitlabbinding_lifecycle.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,15 @@ func (sb *GitLabBinding) Do(ctx context.Context, ps *duckv1.WithPod) {
func (sb *GitLabBinding) Undo(ctx context.Context, ps *duckv1.WithPod) {
spec := ps.Spec.Template.Spec

// Make sure the PodSpec does NOT have the github volume.
// Make sure the PodSpec does NOT have the gitlab volume.
for i, v := range spec.Volumes {
if v.Name == gitlab.VolumeName {
ps.Spec.Template.Spec.Volumes = append(spec.Volumes[:i], spec.Volumes[i+1:]...)
break
}
}

// Make sure that none of the [init]containers have the github volume mount
// Make sure that none of the [init]containers have the gitlab volume mount
for i, c := range spec.InitContainers {
for j, vm := range c.VolumeMounts {
if vm.Name == gitlab.VolumeName {
Expand Down

0 comments on commit 82e0bef

Please sign in to comment.