Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

[RELEASE 0.13] Backport a minimal fix for GitHubSource #1014

Merged
merged 1 commit into from
Mar 10, 2020
Merged

[RELEASE 0.13] Backport a minimal fix for GitHubSource #1014

merged 1 commit into from
Mar 10, 2020

Conversation

mattmoor
Copy link
Member

See #997, #1007, #1009 for additional context.

/assign @lionelvillard

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 10, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2020
@mattmoor
Copy link
Member Author

/retest

@lionelvillard
Copy link
Member

it's failing because the container images haven't been built (by ko I assume):

 image: knative.dev/eventing/cmd/channel_broker

Could it be the latest ko does not support non-ko URL (ko:...) ?

@mattmoor
Copy link
Member Author

@lionelvillard Good catch. No, ko needs to support paths without the scheme, but it's likely it ignored these with --strict. @chaodaiG is ./hack/release.sh being run from HEAD...?

@mattmoor
Copy link
Member Author

/retest

@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@mattmoor
Copy link
Member Author

🤔 Did the other PR not merge yet?

@mattmoor
Copy link
Member Author

It merged, but this is also a different code path that seems to be pulling from HEAD 🤦‍♂

@chizhg
Copy link
Member

chizhg commented Mar 10, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 8b3b3cc into knative:release-0.13 Mar 10, 2020
@mattmoor mattmoor deleted the cp-github-fix branch March 10, 2020 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grantr grantr Awaiting requested review from grantr

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@lionelvillard lionelvillard

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattmoor @lionelvillard @n3wscott @knative-prow-robot @chizhg @googlebot