Fixed Kafka disconnection issue

[slinkydeveloper]

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #999

Proposed Changes

• Wrapped Consume method invocation in a loop, like explained in the example here: https://godoc.org/github.com/Shopify/sarama#ConsumerGroup

[lberk]

@slinkydeveloper looks like this change (as-is) causes a data race?

[slinkydeveloper]

@slinkydeveloper looks like this change (as-is) causes a data race?

Yep i'm investigating, doesn't seem a funny one

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
kafka/common/pkg/kafka/consumer_factory.go	100.0%	90.3%	-9.7

[slinkydeveloper]

/retest

[matzew]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• kafka/OWNERS [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[guimou]

Thanks a lot guys! That will really help as otherwise the solution was not reliable enough to work with. :-)