Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Replace Ceph samples with latest resources #1277

Merged
merged 1 commit into from
May 27, 2020
Merged

Replace Ceph samples with latest resources #1277

merged 1 commit into from
May 27, 2020

Conversation

tom24d
Copy link
Contributor

@tom24d tom24d commented May 27, 2020

Fixes #868

Proposed Changes

  • 🗑️ No more use ContainerSource/v1alpha1.
  • 🧽 Update samples with the latest resources.

Release Note

Ceph source is now available with Deployment + SinkBinding.

Related: #1255

/cc @slinkydeveloper
cc @yuvalif

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 27, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2020
@knative-prow-robot
Copy link
Contributor

Hi @tom24d. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2020
Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, tom24d

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@knative-prow-robot knative-prow-robot merged commit f626c6e into knative:master May 27, 2020
@tom24d tom24d deleted the ceph_update_868 branch May 27, 2020 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ceph] Migrate ceph impl to SinkBinding
4 participants