Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Bump to K8s 18.8 #1555

Merged
merged 12 commits into from
Sep 11, 2020
Merged

Bump to K8s 18.8 #1555

merged 12 commits into from
Sep 11, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Sep 10, 2020

As part of the work to upgrade to k8s 18.8, this is work in progress to update our deps to that and the fixes for resulting fallout.

Proposed Changes

Release Note

- 🧽 Update or clean up current behavior

Uses k8s 18.8 APIs. No new features from them are being used however, just the client code.

- 🗑️ Remove feature or internal logic

Remove camel source from this repo. move it to https://github.com/knative-sandbox/eventing-camel

Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 10, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@vaikas
Copy link
Contributor Author

vaikas commented Sep 10, 2020

Since there's a dependency on the camel-k here, perhaps we should use this opportunity and move it to knative-sandbox before this migration so we can unblock the others?
@nicolaferraro is this something that makes sense to you? And apologies if you're not the right person, did some rudimentary digging and seemed up your alley :)

@nicolaferraro
Copy link
Contributor

Since there's a dependency on the camel-k here, perhaps we should use this opportunity and move it to knative-sandbox before this migration so we can unblock the others?
@nicolaferraro is this something that makes sense to you? And apologies if you're not the right person, did some rudimentary digging and seemed up your alley :)

It makes sense @vaikas. I see the eventing-camel repo is already there. Do you want me to take this task?

@vaikas
Copy link
Contributor Author

vaikas commented Sep 11, 2020

@nicolaferraro Yes please :)

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2020
@vaikas
Copy link
Contributor Author

vaikas commented Sep 11, 2020

@nicolaferraro I pushed the repo to eventing camel. Just cloned the repo there and I'll move all the other bits.

@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@vaikas vaikas changed the title [WIP] Bump to K8s 18.8 Bump to K8s 18.8 Sep 11, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2020
@knative-prow-robot knative-prow-robot merged commit 201452e into knative:master Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants