Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Move GCPPubSub out of contrib dir. #492

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Jul 29, 2019

Stage work related to knative/eventing#1565

Release Note

NONE

/assign @Harwayne

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 29, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 29, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
gcppubsub/pkg/adapter/adapter.go Do not exist 61.0%
gcppubsub/pkg/adapter/pubsub.go Do not exist 66.7%
gcppubsub/pkg/apis/sources/v1alpha1/gcp_pubsub_types.go Do not exist 71.4%
gcppubsub/pkg/apis/sources/v1alpha1/gcp_pubsub_validation.go Do not exist 87.5%
gcppubsub/pkg/apis/sources/v1alpha1/register.go Do not exist 100.0%
gcppubsub/pkg/reconciler/gcppubsubsource.go Do not exist 90.5%
gcppubsub/pkg/reconciler/pubsub_wrapper.go Do not exist 66.7%
gcppubsub/pkg/reconciler/resources/receive_adapter.go Do not exist 100.0%

@vaikas
Copy link
Contributor

vaikas commented Jul 30, 2019

Sorry, I meant we should remove it from this repo to another repo, not to move it to top level. I'm sorry :(

@vaikas
Copy link
Contributor

vaikas commented Jul 30, 2019

actually, this is fine :)

@vaikas
Copy link
Contributor

vaikas commented Jul 30, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [n3wscott,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 40dddfd into knative:master Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants