Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Add eventTypes to importer/source CRDs #506

Merged
merged 37 commits into from
Aug 5, 2019

Conversation

nachocano
Copy link
Contributor

Helps with #1550

Proposed Changes

  • Adding registry-related information (i.e., eventTypes) to AwsSqSSource, KafkaSource, GithubSource, and GCPPubSubSource.

Release Note

AwsSqsSource, KafkaSource, GitHubSource and GCPPubSubSource are now discoverable. By describing their CRDs, you can identify what are the event types they can produce.

GitHub webhooks cannot be created otherwise.
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 5, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 5, 2019
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2019
@knative-prow-robot knative-prow-robot merged commit 21bdfcc into knative:master Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants