Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Remove kafka ccp #515

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Remove kafka ccp #515

merged 2 commits into from
Aug 7, 2019

Conversation

matzew
Copy link
Member

@matzew matzew commented Aug 7, 2019

For 0.9.0 release we need to remove the deprecated Kafka CCP. Besides removing the binaries and the config, the release script was also updated to have the following two kafka artifacts:

  • kafka-importer.yaml: the source/importer
  • kafka-channel.yaml: the CRD based channel

Proposed Changes

  • remove config and binary for Kafka CCP and update the -crd yaml, to only say kafka-channel (since there is only one channel left)

Release Note

depracated Kafka CCP being removed and the CRD based version is now released via kafka-channel.yaml file

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 7, 2019
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 7, 2019
@matzew matzew changed the title WIP: Remove kafka ccp Remove kafka ccp Aug 7, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2019
@matzew
Copy link
Member Author

matzew commented Aug 7, 2019

/test pull-knative-eventing-contrib-build-tests

Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This relates to knative/eventing#1627.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2019
@matzew
Copy link
Member Author

matzew commented Aug 7, 2019

/assign @grantr

@adrcunha
Copy link
Contributor

adrcunha commented Aug 7, 2019

/lgtm

@matzew
Copy link
Member Author

matzew commented Aug 7, 2019

/assign @vaikas-google

@n3wscott
Copy link
Contributor

n3wscott commented Aug 7, 2019

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@knative-prow-robot knative-prow-robot merged commit a6c6b0a into knative:master Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants