Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Don't ignore parsing errors #539

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Conversation

duglin
Copy link

@duglin duglin commented Aug 12, 2019

If the request generates an error (e.g. HMAC verification failed) we shouldn't
just silently ignore it, the event will be nil so there's no point in going on.
We should return/log the error so someone can figure out what's going on.

Signed-off-by: Doug Davis dug@us.ibm.com

/cc @n3wscott

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 12, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2019
@lionelvillard
Copy link
Member

@duglin can you rebase?

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
If the request generates an error (e.g. HMAC verification failed) we shouldn't
just silently ignore it, the event will be nil so there's no point in going on.
We should return/log the error so someone can figure out what's going on.

Signed-off-by: Doug Davis <dug@us.ibm.com>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@duglin
Copy link
Author

duglin commented Aug 12, 2019

done

@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@n3wscott
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duglin, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@knative-prow-robot knative-prow-robot merged commit c6d0097 into knative:master Aug 12, 2019
@duglin duglin deleted the reportError branch August 12, 2019 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants