add couchdb source #541

lionelvillard · 2019-08-12T19:33:29Z

Proposed Changes

Add CouchDB source importer

Bare minimum CouchDB importer. Support polling every 2 seconds for CouchDB database changes.

knative-prow-robot · 2019-08-12T20:24:36Z

The following users are mentioned in OWNERS file(s) but are not members of the knative org.

couchdb-approvers
- couchdb/importer/pkg/adapter/OWNERS
couchdb-reviewers
- couchdb/importer/pkg/adapter/OWNERS

lionelvillard · 2019-08-12T21:25:36Z

/assign @vaikas-google

matzew · 2019-09-10T16:10:37Z

couchdb/source/config/300-couchdbsource.yaml

+  group: sources.eventing.knative.dev
+  names:
+    categories:
+    - all


do we really want that in all ?

yes, to be consistent with the other sources?

matzew · 2019-09-10T16:11:03Z

couchdb/source/config/500-controller.yaml

+          value: knative.dev/sources
+        - name: COUCHDB_RA_IMAGE
+          value: knative.dev/eventing-contrib/couchdb/source/cmd/receive_adapter
+        resources:


are these values guesses ?

just default values.

matzew · 2019-09-10T16:14:15Z

wanna add some basic readme ? I usually hate it when browsing the folders (e.g. /couchdb in this case) and there is zero information

lionelvillard · 2019-09-12T15:43:17Z

@matzew README added!

matzew · 2019-09-24T08:37:43Z

@lionelvillard do you want to do the metrics in a different PR ?

See here for reference: knative/eventing#1693

matzew · 2019-09-24T08:38:17Z

/lgtm
/approve
/hold whether metrics go in here or different PR, up to @lionelvillard

knative-prow-robot · 2019-09-24T08:38:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

matzew · 2019-09-24T08:38:47Z

/hold

lionelvillard · 2019-09-24T13:35:49Z

let's merge this one and let's add the metrics in a different PR. We should really start to think about having a Source SDK.

/hold cancel

lionelvillard · 2019-09-24T14:03:23Z

/test pull-knative-eventing-contrib-integration-tests

matzew · 2019-09-24T16:51:27Z

/test pull-knative-eventing-contrib-integration-tests

lionelvillard · 2019-09-24T17:14:59Z

let's try a rebase...

knative-metrics-robot · 2019-09-24T17:20:05Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
couchdb/source/pkg/apis/sources/v1alpha1/couchdbsource_lifecycle.go	Do not exist	53.8%
couchdb/source/pkg/apis/sources/v1alpha1/couchdbsource_types.go	Do not exist	50.0%
couchdb/source/pkg/apis/sources/v1alpha1/register.go	Do not exist	100.0%

matzew · 2019-09-24T17:21:56Z

/lgtm

On Tue 24. Sep 2019 at 19:20, Knative Metrics Robot < ***@***.***> wrote: The following is the coverage report on pkg/. Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report File Old Coverage New Coverage Delta couchdb/source/pkg/apis/sources/v1alpha1/couchdbsource_lifecycle.go <https://storage.cloud.google.com/knative-prow/pr-logs/pull/knative_eventing-contrib/541/pull-knative-eventing-contrib-go-coverage/1176546136375169024/artifacts/line-cov.html#file0> Do not exist 53.8% couchdb/source/pkg/apis/sources/v1alpha1/couchdbsource_types.go <https://storage.cloud.google.com/knative-prow/pr-logs/pull/knative_eventing-contrib/541/pull-knative-eventing-contrib-go-coverage/1176546136375169024/artifacts/line-cov.html#file1> Do not exist 50.0% couchdb/source/pkg/apis/sources/v1alpha1/register.go <https://storage.cloud.google.com/knative-prow/pr-logs/pull/knative_eventing-contrib/541/pull-knative-eventing-contrib-go-coverage/1176546136375169024/artifacts/line-cov.html#file2> Do not exist 100.0% — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#541?email_source=notifications&email_token=AABGPTUVGZBEY2K4DDWHCVDQLJD4NA5CNFSM4ILEKROKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7PEFXQ#issuecomment-534659806>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABGPTTKHMWMZMQ5MI2BBZDQLJD4NANCNFSM4ILEKROA> .

-- Sent from Gmail Mobile

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 12, 2019

knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 12, 2019

knative-prow-robot requested review from n3wscott and steuhs August 12, 2019 19:33

knative-prow-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 12, 2019

lionelvillard force-pushed the couchdb branch from 716a86e to 17f8f52 Compare August 12, 2019 19:46

knative-prow-robot assigned vaikas Aug 12, 2019

lionelvillard force-pushed the couchdb branch from b90f0a3 to 097923a Compare September 4, 2019 17:22

mattmoor-sockpuppet reviewed Sep 4, 2019

View reviewed changes

lionelvillard force-pushed the couchdb branch from 097923a to 2cd3a19 Compare September 4, 2019 17:38

mattmoor-sockpuppet reviewed Sep 4, 2019

View reviewed changes

lionelvillard force-pushed the couchdb branch from 2cd3a19 to f03085f Compare September 4, 2019 17:39

matzew reviewed Sep 10, 2019

View reviewed changes

lionelvillard force-pushed the couchdb branch from f03085f to ae092b0 Compare September 12, 2019 15:41

mattmoor-sockpuppet reviewed Sep 12, 2019

View reviewed changes

lionelvillard force-pushed the couchdb branch from ae092b0 to fa33053 Compare September 12, 2019 15:41

mattmoor-sockpuppet reviewed Sep 12, 2019

View reviewed changes

lionelvillard force-pushed the couchdb branch from fa33053 to ff85067 Compare September 12, 2019 15:42

mattmoor-sockpuppet reviewed Sep 12, 2019

View reviewed changes

lionelvillard force-pushed the couchdb branch 4 times, most recently from 0d7c2ae to e9b43aa Compare September 12, 2019 17:48

lionelvillard changed the title ~~add couchdb importer~~ add couchdb source Sep 12, 2019

lionelvillard force-pushed the couchdb branch from e9b43aa to 21454f6 Compare September 14, 2019 20:40

knative-prow-robot assigned matzew Sep 24, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2019

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2019

lionelvillard added 11 commits September 24, 2019 13:15

add couchdb importer

281ee96

update dependencies

0922594

add event type registry in CRD

624e31c

add me to the couchdb approver/reviewer list

3d2d310

rename importers to source to be consistent

7da7f8d

Add README and remove OWNERS

9643991

increase code coverage

cb70b64

rebase

f6b5fa1

rebasing and renaming

45090d0

update dependencies

c66ff1a

add owner files

1faa829

lionelvillard force-pushed the couchdb branch from 7fbe749 to 1faa829 Compare September 24, 2019 17:16

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019

knative-prow-robot merged commit 5447e2b into knative:master Sep 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add couchdb source #541

add couchdb source #541

lionelvillard commented Aug 12, 2019 •

edited

Loading

knative-prow-robot commented Aug 12, 2019

lionelvillard commented Aug 12, 2019

matzew Sep 10, 2019

lionelvillard Sep 12, 2019

matzew Sep 10, 2019

lionelvillard Sep 12, 2019

matzew commented Sep 10, 2019

lionelvillard commented Sep 12, 2019

matzew commented Sep 24, 2019

matzew commented Sep 24, 2019

knative-prow-robot commented Sep 24, 2019

matzew commented Sep 24, 2019

lionelvillard commented Sep 24, 2019

lionelvillard commented Sep 24, 2019

matzew commented Sep 24, 2019

lionelvillard commented Sep 24, 2019

knative-metrics-robot commented Sep 24, 2019

matzew commented Sep 24, 2019 via email

add couchdb source #541

add couchdb source #541

Conversation

lionelvillard commented Aug 12, 2019 • edited Loading

Proposed Changes

knative-prow-robot commented Aug 12, 2019

lionelvillard commented Aug 12, 2019

matzew Sep 10, 2019

Choose a reason for hiding this comment

lionelvillard Sep 12, 2019

Choose a reason for hiding this comment

matzew Sep 10, 2019

Choose a reason for hiding this comment

lionelvillard Sep 12, 2019

Choose a reason for hiding this comment

matzew commented Sep 10, 2019

lionelvillard commented Sep 12, 2019

matzew commented Sep 24, 2019

matzew commented Sep 24, 2019

knative-prow-robot commented Sep 24, 2019

matzew commented Sep 24, 2019

lionelvillard commented Sep 24, 2019

lionelvillard commented Sep 24, 2019

matzew commented Sep 24, 2019

lionelvillard commented Sep 24, 2019

knative-metrics-robot commented Sep 24, 2019

matzew commented Sep 24, 2019 via email

lionelvillard commented Aug 12, 2019 •

edited

Loading