Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Revert upgrade to Beta serving. Use Alpha api but Beta shape. Lemonaid. #565

Merged
merged 2 commits into from
Sep 3, 2019

Conversation

n3wscott
Copy link
Contributor

Fixes #562

Proposed Changes

  • Use Alpha api but Beta shape. Lemonaid.

Release Note

Github will launch as 1valpha1 serving resource.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 30, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 30, 2019
@n3wscott
Copy link
Contributor Author

/assign @grantr

@grantr
Copy link
Contributor

grantr commented Aug 30, 2019

What about https://github.com/knative/eventing-contrib/blob/master/github/pkg/apis/addtoscheme_serving_v1beta1.go?

Does this change trigger #481, which was the original reason for #489 which updated to v1beta1?

Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 13a4d11 into knative:master Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHubSource shouldn't use Service v1beta1 yet
4 participants