This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Kafka metrics for the channel #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/L
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nachocano
reviewed
Sep 23, 2019
kafka/channel/cmd/webhook/main.go
Outdated
| @@ -18,6 +18,7 @@ package main | |||
| import ( | |||
| "context" | |||
| "flag" | |||
| "knative.dev/pkg/metrics" | |||
nachocano
reviewed
Sep 23, 2019
kafka/channel/cmd/webhook/main.go
Outdated
| // Watch the observability config map | ||
| configMapWatcher.Watch(metrics.ConfigMapName(), metrics.UpdateExporterFromConfigMap(component, logger)) | ||
|
|
||
|
|
There was a problem hiding this comment.
remove a couple of these empty lines?
nachocano
reviewed
Sep 23, 2019
kafka/docs/metrics.md
Outdated
| 9090 | ||
| ``` | ||
|
|
||
| Access Prometheus targets endpoint [http://localhost:9090/targets](http://localhost:9090/targets). Now, the **kafkachannel_controller**, **kafkachannel_dispatcher** and **kafkachannel_dispatcher** jobs should be up. |
There was a problem hiding this comment.
and kafkachannel_webhook ?
|
@matzew very trivial comments and good to go! |
75 tasks
|
@nachocano thanks for the review! I've patched the PR |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps knative/eventing#1693.
Proposed Changes
/assign @nachocano