This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Source registry #631
Merged
Source registry #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub webhooks cannot be created otherwise.
knative-prow-robot
added
the
size/L
knative-prow-robot
requested review from
bbrowning,
evankanderson and
lionelvillard
|
/lgtm |
knative-prow-robot
added
lgtm
|
how come this affects the natss e2e? /test pull-knative-eventing-contrib-integration-tests |
|
the problem is that the e2e use eventing head, and there has been some changes to the channel dispatcher and receiver... will need to fix that in order for this to pass... |
|
/test pull-knative-eventing-contrib-integration-tests |
|
/test pull-knative-eventing-contrib-integration-tests |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, n3wscott, nachocano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with knative/eventing#1550
Proposed Changes
Release Note