Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Backport usage of Destination in CamelSource (#700) to release-0.10 b… #718

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Backport usage of Destination in CamelSource (#700) to release-0.10 b… #718

merged 1 commit into from
Nov 21, 2019

Conversation

nicolaferraro
Copy link
Contributor

…ranch

Fixes #694 on 0.10.x

Proposed Changes

Release Note

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 11, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2019
@knative-prow-robot
Copy link
Contributor

Hi @nicolaferraro. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lionelvillard
Copy link
Member

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2019
@nicolaferraro
Copy link
Contributor Author

/retest

2 similar comments
@matzew
Copy link
Member

matzew commented Nov 13, 2019

/retest

@nicolaferraro
Copy link
Contributor Author

/retest

@nicolaferraro
Copy link
Contributor Author

no way today..

@lionelvillard
Copy link
Member

/test pull-knative-eventing-contrib-integration-tests

@chizhg
Copy link
Member

chizhg commented Nov 18, 2019

There is some change for the tests in the release-0.10 branch, please update your local release-0.10 and merge into this PR.

@nicolaferraro
Copy link
Contributor Author

nicolaferraro commented Nov 21, 2019 •
edited
Loading

Thanks @chizhg, lionelvillard. It is passing tests now.

matzew
matzew approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, nicolaferraro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@knative-prow-robot knative-prow-robot merged commit 302c5e0 into knative:release-0.10 Nov 21, 2019
nicolaferraro added a commit to nicolaferraro/eventing-contrib that referenced this pull request Nov 21, 2019
@nicolaferraro
Backport usage of Destination in CamelSource (knative#700) to release…
8ca39df 
…-0.10 branch (knative#718)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matzew matzew matzew approved these changes

@bbrowning bbrowning Awaiting requested review from bbrowning

@evankanderson evankanderson Awaiting requested review from evankanderson

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolaferraro @knative-prow-robot @lionelvillard @matzew @chizhg @googlebot