-
Notifications
You must be signed in to change notification settings - Fork 225
Fixing issue with incorrect conversion of sqs SentTimestamp #996
Conversation
SentTimestamp is in millisecond format but code was expecting second format
Welcome @AceHack! It looks like this is your first PR to knative/eventing-contrib 🎉 |
Hi @AceHack. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Said nanoseconds when really it was milliseconds
/assign @Harwayne |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AceHack, nachocano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixing nanosecond time conversion
/retest |
@AceHack: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
How can I do the following the bot suggests? |
/ok-to-test
…On Fri, Mar 6, 2020 at 1:46 PM Aaron Stainback ***@***.***> wrote:
How can I do the following the bot suggests?
"Regular contributors should join the org to skip this step"
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#996?email_source=notifications&email_token=ABD65DDSWMZUUAGIFV3JJ7LRGFVMDA5CNFSM4LDHU5Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOC6UVQ#issuecomment-595978838>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD65DGD4JHY53XS7ZAFM4DRGFVMDANCNFSM4LDHU5QQ>
.
|
hmm click on the original link that said join the org, and there I think you can ask to join knative. Otherwise some repo admin might be able to add you? @grantr might know? |
The following is the coverage report on the affected files.
|
It did not ask anywhere for me to join the org |
/lgtm |
the link here? #996 (comment) |
/test pull-knative-eventing-contrib-integration-tests |
/retest |
Can I reference the updated docker image now? Does the build process automatically create a new docker image I can reference? How can I find that tag if so? Thanks. |
SentTimestamp is in millisecond format but code was expecting second format
Fixes #
#993
Proposed Changes
Fixing issue with incorrect conversion of sqs SentTimestamp