Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Fixing issue with incorrect conversion of sqs SentTimestamp #996

Merged
merged 3 commits into from
Mar 8, 2020
Merged

Fixing issue with incorrect conversion of sqs SentTimestamp #996

merged 3 commits into from
Mar 8, 2020

Conversation

AceHack
Copy link
Contributor

@AceHack AceHack commented Mar 6, 2020

SentTimestamp is in millisecond format but code was expecting second format

Fixes #

#993

Proposed Changes

  • 🐛 Fix bug

Fixing issue with incorrect conversion of sqs SentTimestamp

SentTimestamp is in millisecond format but code was expecting second format
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 6, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2020
@knative-prow-robot
Copy link
Contributor

Welcome @AceHack! It looks like this is your first PR to knative/eventing-contrib 🎉

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2020
@knative-prow-robot
Copy link
Contributor

Hi @AceHack. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Said nanoseconds when really it was milliseconds
@AceHack
Copy link
Contributor Author

AceHack commented Mar 6, 2020

/assign @Harwayne

@nachocano
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AceHack, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
Fixing nanosecond time conversion
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020
@AceHack
Copy link
Contributor Author

AceHack commented Mar 6, 2020

/retest

@knative-prow-robot
Copy link
Contributor

@AceHack: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AceHack
Copy link
Contributor Author

AceHack commented Mar 6, 2020

How can I do the following the bot suggests?
"Regular contributors should join the org to skip this step"

@nachocano
Copy link
Contributor

nachocano commented Mar 6, 2020 via email

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2020
@nachocano
Copy link
Contributor

How can I do the following the bot suggests?
"Regular contributors should join the org to skip this step"

hmm click on the original link that said join the org, and there I think you can ask to join knative. Otherwise some repo admin might be able to add you? @grantr might know?

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
awssqs/pkg/adapter/adapter.go 65.7% 66.2% 0.5

@AceHack
Copy link
Contributor Author

AceHack commented Mar 7, 2020

It did not ask anywhere for me to join the org

@nachocano
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2020
@nachocano
Copy link
Contributor

It did not ask anywhere for me to join the org

the link here? #996 (comment)

@AceHack
Copy link
Contributor Author

AceHack commented Mar 8, 2020

/test pull-knative-eventing-contrib-integration-tests

@AceHack
Copy link
Contributor Author

AceHack commented Mar 8, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 1fa88fa into knative:master Mar 8, 2020
@AceHack
Copy link
Contributor Author

AceHack commented Mar 8, 2020

Can I reference the updated docker image now? Does the build process automatically create a new docker image I can reference? How can I find that tag if so? Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants