This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Update Kafka consumer group error message #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
knative-prow-robot
added
the
needs-ok-to-test
|
@matzew, can you take a look at this one? |
|
/ok-to-test |
knative-prow-robot
removed
the
needs-ok-to-test
|
/lgtm |
|
Can someone merge this one, thanks. |
|
/lgtm
/approve
/cc @n3wscott
On Thu 4. Apr 2019 at 18:54, James Dubee ***@***.***> wrote:
Can someone merge this one, thanks.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#301 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJnzqYgH0YntER8ctERuoCnpyCrXGNNks5vdi5CgaJpZM4cOcaj>
.
--
Sent from Gmail Mobile
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dubee, evankanderson, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/retest
On Thu 4. Apr 2019 at 22:30, Knative Prow Robot ***@***.***> wrote:
@dubee <https://github.com/dubee>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-knative-eventing-sources-integration-tests 5fa8d9f
<5fa8d9f>
link
<https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_eventing-sources/301/pull-knative-eventing-sources-integration-tests/1113897636106080256/> /test
pull-knative-eventing-sources-integration-tests
Full PR test history
<https://gubernator.knative.dev/pr/knative_eventing-sources/301>. Your PR
dashboard <https://gubernator.knative.dev/pr/dubee>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#301 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJnzhE-0wLv3zg_jAMc8jdYGm5koDa0ks5vdmDFgaJpZM4cOcaj>
.
--
Sent from Gmail Mobile
|
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the consumer group error message format. Currently when a consumer group error occurs, the error message looks slightly malformed as shown below.