Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Add OWNERS for a few of the Source implementations #349

Merged
merged 1 commit into from
May 2, 2019

Conversation

Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Apr 5, 2019

Proposed Changes

  • Add OWNERS for a few of the Source implementations, based on those who volunteered during the WG call.

This will only be submitted once all of the following people have LGTM'ed it:

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 5, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 5, 2019
@Harwayne
Copy link
Contributor Author

Harwayne commented Apr 5, 2019

/assign @vaikas-google
/assign @bbrowning
/assign @rootfs
/assign @matzew

@Harwayne
Copy link
Contributor Author

Harwayne commented Apr 5, 2019

LGTM (prow won't let me LGTM my own PR).

@matzew
Copy link
Member

matzew commented Apr 6, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2019
@bbrowning
Copy link
Contributor

/lgtm

1 similar comment
@rootfs
Copy link

rootfs commented Apr 10, 2019

/lgtm

@Harwayne
Copy link
Contributor Author

Ping @vaikas-google

@vaikas
Copy link
Contributor

vaikas commented May 2, 2019

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2019
@vaikas
Copy link
Contributor

vaikas commented May 2, 2019

/test pull-knative-eventing-sources-integration-tests

@knative-prow-robot knative-prow-robot merged commit d70c24f into knative:master May 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants