Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Delete moved CronJobSource. #368

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

n3wscott
Copy link
Contributor

Follow-up to knative/eventing#1092

Proposed Changes

  • Delete moved CronJobSource

Release Note

CronJobSource now comes from installing eventing.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 24, 2019
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2019
@n3wscott
Copy link
Contributor Author

/hold
until knative/eventing#1092 lands

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
@matzew
Copy link
Member

matzew commented Apr 25, 2019

@n3wscott
Copy link
Contributor Author

The samples will be moved to Docs.

@matzew
Copy link
Member

matzew commented Apr 25, 2019

/lgtm

😄

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@n3wscott
Copy link
Contributor Author

knative/eventing#1092 landed

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2019
@knative-prow-robot knative-prow-robot merged commit 22e5103 into knative:master Apr 25, 2019
@n3wscott
Copy link
Contributor Author

Related to knative/docs#1235

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants