Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Updating Kafka CloudEvent source #411

Merged
merged 3 commits into from
May 11, 2019

Conversation

nachocano
Copy link
Contributor

Fixes knative/eventing#1205

Proposed Changes

  • Changing Kafka CloudEvent source to include more information than just the topic.
  • Changed it from <topic> to /apis/v1/namespaces/<namespace>/kafkasources/<source_name>#<topic>

Release Note

Updating Kafka CloudEvent source. This is a breaking change in the sense that if Triggers have been created listening for events on a particular Kafka topic, they will have to update their source field inside SourceAndType filter to listen to /apis/v1/namespaces/<namespace>/kafkasources/<source_name>#<topic>

nachocano added 3 commits May 10, 2019 14:37
Adding name and namespace env variables to properly set it up.
# Conflicts:
#	contrib/kafka/pkg/adapter/adapter.go
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 10, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 10, 2019
@nachocano
Copy link
Contributor Author

/assign @matzew

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-sources-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
contrib/kafka/pkg/adapter/adapter.go 14.5% 41.2% 26.7
contrib/kafka/pkg/apis/sources/v1alpha1/kafka_types.go 100.0% 93.3% -6.7
contrib/kafka/pkg/reconciler/kafkasource.go 86.0% 89.2% 3.2

@matzew
Copy link
Member

matzew commented May 11, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2019
@knative-prow-robot knative-prow-robot merged commit fb3fa95 into knative:master May 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change CloudEvent source attribute in KafkaSource
5 participants