Skip to content

Commit

Permalink
Add note to channel spec regarding channel subscription spec (#3132)
Browse files Browse the repository at this point in the history
* Add note to channel spec regarding channel subscription spec

The spec.subscription fields shouldn't be set directly, rather
it should be set via the subscriptions themselves and then the status
should be propogated via the channel.

* Update wording based on feedback to clarify backing channel & channel

* linting suggestion change

Co-authored-by: Matt Moore <mattmoor@vmware.com>

* change CR to custom object

Co-authored-by: Adam Harwayne <harwayne@google.com>

* more linting

Co-authored-by: Matt Moore <mattmoor@vmware.com>

Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Adam Harwayne <harwayne@google.com>
  • Loading branch information
3 people authored May 15, 2020
1 parent e97ffcc commit b3a3da6
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions docs/spec/channel.md
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ Each channel CRD MUST contain an array of subscribers:
Each channel CRD MUST contain an array of subscribers:
[`spec.subscribers`](https://github.com/knative/eventing/blob/master/pkg/apis/duck/v1beta1/subscribable_types.go)

Note: The array of subscribers MUST NOT be set directly on the generic Channel
custom object, but rather appended to the backing channel by the subscription
itself.

#### Status Requirements

##### v1alpha1 Status
Expand Down

0 comments on commit b3a3da6

Please sign in to comment.