Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka channel dispatcher logs HTTP error 502 on malformed response from an event handling client function #4071

Closed
ntzlqx opened this issue Sep 17, 2020 · 2 comments · Fixed by #4083
Assignees

Comments

@ntzlqx
Copy link

ntzlqx commented Sep 17, 2020

Describe the bug
The issue does not result in a real failure if the response is not meaningful, but creates confusion in logs and traces.
There is an explicit conversion in code of a http status code 200 to 502 without some additional logging context

Expected behavior
Clear indication that the client function responded with a malformed cloudevent

To Reproduce
Respond from a kn handler function with 200 and something else (non empty response body) such as string or anything other than cloud event

0.17.3

Additional context
Add any other context about the problem here such as proposed priority

@slinkydeveloper slinkydeveloper transferred this issue from knative/eventing Sep 18, 2020
@slinkydeveloper slinkydeveloper transferred this issue from knative/eventing-contrib Sep 18, 2020
@slinkydeveloper slinkydeveloper self-assigned this Sep 18, 2020
slinkydeveloper added a commit to slinkydeveloper/eventing that referenced this issue Sep 18, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@ntzlqx
Copy link
Author

ntzlqx commented Sep 18, 2020

/approve

@ntzlqx
Copy link
Author

ntzlqx commented Sep 18, 2020

Thank you guys!

knative-prow-robot pushed a commit that referenced this issue Sep 18, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants