Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing subscriberUri path in additionalPrinterColumns #3013

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

matzew
Copy link
Member

@matzew matzew commented Apr 20, 2020

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #3012

Proposed Changes

  • Correcting the jsonpath in triggers.eventing.knative.dev CRD: (notice the different case of subscriberURI vs subscriberUri )

Release Note

-->

- 🐛 Fix bug SUBSCRIBER_URI was not printed on for triggers

Docs

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 20, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 20, 2020
@aliok
Copy link
Member

aliok commented Apr 20, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit e17f3ec into knative:master Apr 20, 2020
@aliok aliok mentioned this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

triggers.eventing.knative.dev CRD, wrong subscriberUri jsonpath in additionalPrinterColumns
4 participants