Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to channel spec regarding channel subscription spec #3132

Merged
merged 5 commits into from
May 15, 2020
+4 −0
Merged

Add note to channel spec regarding channel subscription spec #3132

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7db555
Add note to channel spec regarding channel subscription spec
lberk May 12, 2020
7bb5672
Update wording based on feedback to clarify backing channel & channel
lberk May 14, 2020
7465c76
linting suggestion change
lberk May 14, 2020
2837ca2
change CR to custom object
lberk May 15, 2020
e53fb4d
more linting
lberk May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/spec/channel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,9 @@ Each channel CRD MUST contain an array of subscribers:
Each channel CRD MUST contain an array of subscribers:
[`spec.subscribers`](https://github.com/knative/eventing/blob/master/pkg/apis/duck/v1beta1/subscribable_types.go)

Note: the array of subscribers MUST NOT be set directly on the channel, but
rather appended by the subscription itself.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means, we need to disable direct setting on IMC and other channels in the code as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliok -- ok I've updated, please let me know what you think!


#### Status Requirements

##### v1alpha1 Status
Expand Down