Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Broker control plane tests for Broker v1beta1 #3214

Merged
merged 6 commits into from
May 29, 2020
Merged

Add Broker control plane tests for Broker v1beta1 #3214

merged 6 commits into from
May 29, 2020

Conversation

lberk
Copy link
Member

@lberk lberk commented May 27, 2020

Fixes: #2704

Tests if the broker control plane:

  • Trigger can be created before Broker (with attributes filter)
  • Broker can be created and progresses to Ready
  • Ready Broker is Addressable
  • Trigger with Ready broker progresses to Ready
  • Ready Trigger includes status.subscriberUri

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 27, 2020
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2020
@grantr
Copy link
Contributor

grantr commented May 27, 2020

/cc grantr

@knative-prow-robot knative-prow-robot requested a review from grantr May 27, 2020 20:32
@lberk
Copy link
Member Author

lberk commented May 27, 2020

/test pull-knative-eventing-unit-tests

@lberk
Copy link
Member Author

lberk commented May 27, 2020

/test pull-knative-eventing-unit-tests
(something something about insanity and repeatedly trying things :D)

@grantr
Copy link
Contributor

grantr commented May 27, 2020

Something strange about this run: https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/knative_eventing/3214/pull-knative-eventing-unit-tests/1265763661318721536

All tests passed, but the run still failed (return code 2)

@matzew
Copy link
Member

matzew commented May 28, 2020

/test pull-knative-eventing-unit-tests

@aliok
Copy link
Member

aliok commented May 28, 2020 

test/conformance/helpers/broker_control_plane_test_helper.go:129:3: Fatalf call has error-wrapping directive %w

This is probably the cause for the failing Prow job.

aliok
aliok approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Great stuff overall :)
Left some minor comments.

aliok
aliok approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2020
matzew
matzew approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2020
@matzew
Copy link
Member

matzew commented May 29, 2020

/test all

@matzew
Copy link
Member

matzew commented May 29, 2020

/retest

1 similar comment
@matzew
Copy link
Member

matzew commented May 29, 2020

/retest

lberk added 6 commits May 29, 2020 10:29
@lberk
Add Broker control plane tests for Broker v1beta1
da999c9
@lberk
Change Fatalf %w to %v's
909ed62
@lberk
Drop unused vars, add additional test
ce2a1b5 
Add an additional test (adding broker to trigger-no-broker and
ensuring status reflects subscriberURI)

Drop unused variables from function parameters

Abstract component names to variables
@lberk
Add text describing the six different tests run
16e02f1
@lberk
Modify comment structure, increase timeout
f74fe2d
@lberk
Rebase and remove ChannelBrokerClassValue reference
655ca29
@lberk lberk force-pushed the broker-control-plane-tests branch from cbddcc3 to 655ca29 Compare May 29, 2020 14:37
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 29, 2020
@vaikas
Copy link
Contributor

vaikas commented May 29, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lberk, matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lberk
Copy link
Member Author

lberk commented May 29, 2020

/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot merged commit 022e95a into knative:master May 29, 2020
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
@aliok aliok mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi left review comments

@aliok aliok aliok approved these changes

@matzew matzew matzew approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@yt3liu yt3liu Awaiting requested review from yt3liu

@grantr grantr Awaiting requested review from grantr

Assignees

@matzew matzew

@aliok aliok

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broker conformance test: Control plane
8 participants
@lberk @grantr @matzew @aliok @vaikas @knative-prow-robot @pierDipi @googlebot