Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance tests for channel control plane aggregated addressable resolver ClusterRole #3219

Merged
merged 1 commit into from
May 29, 2020
Merged

Conformance tests for channel control plane aggregated addressable resolver ClusterRole #3219

merged 1 commit into from
May 29, 2020

Conversation

aliok
Copy link
Member

@aliok aliok commented May 28, 2020 •
edited
Loading

Fixes #1959

Proposed Changes

  • Conformance tests for control plane aggregated addressable resolver ClusterRole
  • Extracted some functionality in similar conformance tests into a common place

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 28, 2020
@knative-prow-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 28, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label May 28, 2020
@aliok aliok changed the title Conformance tests for channel control plane aggregated addressable re… Conformance tests for channel control plane aggregated addressable resolver ClusterRole May 28, 2020
@aliok aliok force-pushed the conformance-test-aggregated-addressable-resolver branch from 03382a9 to 11950a5 Compare May 29, 2020 07:02
@aliok aliok marked this pull request as ready for review May 29, 2020 07:02
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 29, 2020
mattmoor
mattmoor reviewed May 29, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

test/conformance/README.md Outdated Show resolved Hide resolved
@aliok aliok force-pushed the conformance-test-aggregated-addressable-resolver branch from 11950a5 to 1a85431 Compare May 29, 2020 07:06
pierDipi
pierDipi approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2020
matzew
matzew approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2020
@knative-prow-robot knative-prow-robot merged commit 8cb8385 into knative:master May 29, 2020
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
@aliok aliok deleted the conformance-test-aggregated-addressable-resolver branch April 28, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@pierDipi pierDipi pierDipi approved these changes

@matzew matzew matzew approved these changes

@chizhg chizhg Awaiting requested review from chizhg

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@matzew matzew

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conformance testing for channel control plane aggregated addressable resolver ClusterRole
6 participants
@aliok @knative-prow-robot @matzew @mattmoor @pierDipi @googlebot