Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an error if the test client cannot getTracingConfig #3608

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Return an error if the test client cannot getTracingConfig #3608

merged 1 commit into from
Jul 16, 2020

Conversation

lberk
Copy link
Member

@lberk lberk commented Jul 16, 2020

Was leading to errors within the tests themselves of invalid pod
EnvVars (blank) when the config wasn't available.

@lberk
Return an error if the test client cannot getTracingConfig
02a9886 
Was leading to errors within the tests themselves of invalid pod
EnvVars (blank) when the config wasn't available.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 16, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jul 16, 2020
pierDipi
pierDipi approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@vaikas
Copy link
Contributor

vaikas commented Jul 16, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@knative-prow-robot knative-prow-robot merged commit a0a5daf into knative:master Jul 16, 2020
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@chizhg chizhg Awaiting requested review from chizhg

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@vaikas vaikas

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lberk @vaikas @knative-prow-robot @pierDipi @googlebot