Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add broker developers as system integrator personas #3668

Merged
merged 4 commits into from
Jul 22, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 21, 2020

Add Broker developer as an example of a System Integrator. We currently list only new Event Source, Channel implementors as System Integrators, with the addition of Broker Classes, we should add a Broker implementor as this type as well.

Proposed Changes

  • Add Broker implementor as System Integrator persona.

Release Note

- 🧽 Update or clean up current behavior
Add Broker implementor as a System Integrator persona.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 21, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2020
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space.

docs/personas.md Outdated Show resolved Hide resolved
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

@vaikas
Copy link
Contributor Author

vaikas commented Jul 21, 2020

Link works, link checker is wrong from what I can tell. I click on the file view it and click it and it works.

@pierDipi
Copy link
Member

Is it blocking for merging?

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@vaikas
Copy link
Contributor Author

vaikas commented Jul 21, 2020

Nah, I don't think so, but I did see the error and checked the link. If it was really b0rk3n I would have fixed it :)

@pierDipi
Copy link
Member

I saw it :)

@pierDipi
Copy link
Member

Not mergeable. Job pull-knative-eventing-build-tests has not succeeded.

:(

@vaikas
Copy link
Contributor Author

vaikas commented Jul 21, 2020

I guess it's just not blocking in docs repo :) I think because it's ran as part of the build tests and not separate test?

@chizhg
Copy link
Member

chizhg commented Jul 21, 2020

/retest

@chizhg
Copy link
Member

chizhg commented Jul 21, 2020

The error is:

docs/personas.md
	ERROR	https://en.wikipedia.org/wiki/Persona_(user_experience
		Not Found (HTTP error 404)

It looks like a bug for the tool we use for checking links, but I tried changing the link to <https://en.wikipedia.org/wiki/Persona_\(user_experience\)> and it worked on my local. Could you also try that in this PR?

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@vaikas
Copy link
Contributor Author

vaikas commented Jul 22, 2020

Thanks @chizhg !!

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaikas
Copy link
Contributor Author

vaikas commented Jul 22, 2020

/test pull-knative-eventing-unit-tests

@knative-prow-robot knative-prow-robot merged commit 46fc727 into knative:master Jul 22, 2020
@vaikas vaikas deleted the system-integrator-update branch July 22, 2020 10:08
@vaikas
Copy link
Contributor Author

vaikas commented Jul 22, 2020

FYI, the linter here is using different methods:
https://github.com/knative/eventing/pull/3682/files

I'll open an issue about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants