-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add broker developers as system integrator personas #3668
add broker developers as system integrator personas #3668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
Link works, link checker is wrong from what I can tell. I click on the file view it and click it and it works. |
Is it blocking for merging? /lgtm |
Nah, I don't think so, but I did see the error and checked the link. If it was really b0rk3n I would have fixed it :) |
I saw it :) |
:( |
I guess it's just not blocking in docs repo :) I think because it's ran as part of the build tests and not separate test? |
/retest |
The error is:
It looks like a bug for the tool we use for checking links, but I tried changing the link to |
Thanks @chizhg !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-knative-eventing-unit-tests |
FYI, the linter here is using different methods: I'll open an issue about it. |
Add Broker developer as an example of a System Integrator. We currently list only new Event Source, Channel implementors as System Integrators, with the addition of Broker Classes, we should add a Broker implementor as this type as well.
Proposed Changes
Release Note
Docs