retry on webhook failures #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/L
knative-prow-robot
added
the
area/test-and-release
|
Worked, just retesting for fun and profit |
|
/test pull-knative-eventing-integration-tests |
pierDipi
reviewed
Jul 22, 2020
| return strings.Contains(err.Error(), "eventing-webhook.knative-eventing") | ||
| } | ||
|
|
||
| func (c *Client) RetryWebhookErrors(updater func(int) error) error { |
There was a problem hiding this comment.
I can, but if this works, I was thinking of hoisting it to pkg so, then it's just a replace here? Makes sense?
pierDipi
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
The issue seems to be mitigated https://prow.knative.dev/pr-history/?org=knative&repo=eventing&pr=3678 so
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around #knative/pkg#1509
Proposed Changes
Release Note
Docs