replace fatalf with logf in retry loop #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
knative-prow-robot
added
area/test-and-release
knative-prow-robot
added
the
do-not-merge/hold
pierDipi
reviewed
Jul 28, 2020
test/lib/creation.go
Outdated
| @@ -107,7 +107,7 @@ func (c *Client) CreateChannelWithDefaultOrFail(channel *messagingv1beta1.Channe | |||
| err := c.RetryWebhookErrors(func(attempts int) (err error) { | |||
| _, e := channels.Create(channel) | |||
| if e != nil { | |||
| c.T.Fatalf("Failed to create channel %q: %v", channel.Name, e) | |||
| c.T.Errorf("Failed to create channel %q: %v", channel.Name, e) | |||
There was a problem hiding this comment.
Should we return the error instead of Errorf?
/hold
There was a problem hiding this comment.
And then it will fail after all retries
There was a problem hiding this comment.
Changed to Logf so that if things don't work after retries, it will fail.
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests: |
knative-prow-robot
added
size/M
knative-prow-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
vaikas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had neglected to change a few Fatalf calls to Errorf in the retry loops. Hence no retry, hence test failures due to webhook failing.
Proposed Changes
Release Note
Docs