-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy additional information as extensions of CE in APIServerSource #3741
Copy additional information as extensions of CE in APIServerSource #3741
Conversation
/assign @nachocano @rhuss |
/assign @lionelvillard |
/lgtm Can you check if there is an example in knative/docs regarding showing the produced event, and add the extension there as well? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danyinggu, nachocano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
Sure. I just edited the description and release note of this PR. I will change the docs to add these additional attributes. Thanks for the reminder! :) |
/lgtm |
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:
|
/retest |
Helps with #3675
Proposed Changes
The CloudEvent has
name
,kind
andnamespace
as attributes in the extension:Release Note
Docs