Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put the waiting of kresources in a retry loop for webhook failures #3751

Merged
merged 1 commit into from
Jul 29, 2020
Merged

put the waiting of kresources in a retry loop for webhook failures #3751

merged 1 commit into from
Jul 29, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 29, 2020

Fixes #3750

Proposed Changes

  • Put the test code that waits for resources in a retry loop to work around webhook failures.

Release Note

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 29, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2020
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 29, 2020
pierDipi
pierDipi approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 324a54f into knative:master Jul 29, 2020
@vaikas vaikas deleted the issue-3750 branch August 4, 2020 08:14
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@chizhg chizhg Awaiting requested review from chizhg

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to get resources ready failing with webhook.
4 participants
@vaikas @knative-prow-robot @pierDipi @googlebot