Regroup additional printer columns #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Put READY and REASON columns at right most position
knative-prow-robot
added
the
size/L
pierDipi
reviewed
Aug 3, 2020
matzew
reviewed
Aug 3, 2020
| @@ -38,18 +38,18 @@ spec: | |||
| # see issue: https://github.com/knative/serving/issues/912 | |||
| x-kubernetes-preserve-unknown-fields: true | |||
| additionalPrinterColumns: | |||
| - name: Ready | |||
There was a problem hiding this comment.
@navidshaikh what's the motivation for this kind of re-grouping ?
There was a problem hiding this comment.
- The value for
REASONcould be empty if resource is READY, thus printing an empty column in between non empty columns - If resource is not
READY, we can addreason:messageforREASONcolumn and keeping the variable length cell at the right (easy to parse) - To keep it consistent with how serving resources' fields are grouped
There was a problem hiding this comment.
thanks for the feedback, @navidshaikh
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
READYandREASONcolumns at the right most position