Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay when to shutdown the mtping adapter #3831

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • Make sure not to stop the mtping adapter to close to the minute during a graceful shutdown.

Release Note

- 🐛 Fix bug
PingSource does not lose events anymore when being shutdown close to the minute

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 13, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
cmd/mtping/main.go Outdated Show resolved Hide resolved
@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-conformance-tests
/test pull-knative-eventing-integration-tests

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestPingSourceV1Beta1EventTypes
test/e2e.TestPingSourceV1Beta1
test/e2e.TestPingSourceV1Alpha2
test/e2e.TestTriggerDependencyAnnotation
test/e2e.TestPingSourceV1Alpha2EventTypes

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/mtping/adapter.go 87.5% 60.9% -26.6
pkg/adapter/mtping/context.go Do not exist 100.0%

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 52a210f into knative:master Aug 17, 2020
@lionelvillard lionelvillard deleted the delay-shutdown branch September 3, 2020 15:29
@lionelvillard lionelvillard restored the delay-shutdown branch September 3, 2020 15:42
@lionelvillard lionelvillard deleted the delay-shutdown branch September 3, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants