Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl explain for Trigger #3845

Merged
merged 6 commits into from
Aug 14, 2020
Merged

kubectl explain for Trigger #3845

merged 6 commits into from
Aug 14, 2020

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Aug 14, 2020 •
edited
Loading

Part of #3054

Proposed Changes

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 14, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2020
@nlopezgi nlopezgi changed the title [WIP] - Split off #3832 kubectl explain for Trigger Aug 14, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2020
@nlopezgi
Copy link
Contributor Author

this is ready for review, fyi @lionelvillard

pierDipi
pierDipi reviewed Aug 14, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

config/core/resources/trigger.yaml
@@ -55,22 +55,22 @@ spec:
properties:
broker:
type: string
description: "Broker that this trigger receives events from. If not specified, will default to 'default'."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" If not specified, will default to 'default'.", isn't it valid anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this following changes from #3573 (which I forgot to mention this PR supersedes). Let me know if you think I should add it back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this defaulting behavior exists and we should mention it in the description. Also, I see that Ville there leaves this https://github.com/knative/eventing/pull/3573/files#diff-35c872630bcc973ea91f0d72122bb2f7R60 untouched, and removes that from the trigger_types.go, but I'm not sure why.
WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default behavior exists in v1beta1, not v1. I would add it just in the v1beta1 schema.

Copy link
Member

@pierDipi pierDipi Aug 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, only v1beta1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added it here for v1beta1 schema.

pkg/apis/eventing/v1/trigger_types.go Show resolved Hide resolved
@nlopezgi
Copy link
Contributor Author

This PR supersedes #3573. I loosely took some modifications from that PR and integrated them here (others were part of the generated bits, so I left unchanged). fyi @pierDipi thanks for the review!

@nlopezgi nlopezgi mentioned this pull request Aug 14, 2020
Merged
@lionelvillard
Copy link
Member

/approve

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2020
pierDipi
pierDipi approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, nlopezgi, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi
Copy link
Contributor Author

addressed comments. Should be ready to go in once tests pass. Thanks for the reviews and clarifications @pierDipi @lionelvillard

@pierDipi
Copy link
Member 

=== CONT  TestChannelDataPlaneSuccess/InMemoryChannel-messaging.knative.dev/v1/min-event_encoding_structured_version_1.0
    creation.go:85: Failed to create "InMemoryChannel" "min-event-structured-10-ch": conversion webhook for messaging.knative.dev/v1, Kind=InMemoryChannel failed: Post https://eventing-webhook.knative-eventing-mfky5ppxta.svc:443/?timeout=30s: service "eventing-webhook" not found
=== CONT  TestChannelDataPlaneSuccess/InMemoryChannel-messaging.knative.dev/v1/min-event_encoding_structured_version_1.0
    creation.go:85: Failed to create "InMemoryChannel" "min-event-structured-10-ch": conversion webhook for messaging.knative.dev/v1, Kind=InMemoryChannel failed: Post https://eventing-webhook.knative-eventing-mfky5ppxta.svc:443/?timeout=30s: service "eventing-webhook" not found
=== CONT  TestChannelDataPlaneSuccess/InMemoryChannel-messaging.knative.dev/v1/min-event_encoding_structured_version_1.0
    creation.go:85: Failed to create "InMemoryChannel" "min-event-structured-10-ch": conversion webhook for messaging.knative.dev/v1, Kind=InMemoryChannel failed: Post https://eventing-webhook.knative-eventing-mfky5ppxta.svc:443/?timeout=30s: service "eventing-webhook" not found
=== CONT  TestChannelDataPlaneSuccess/InMemoryChannel-messaging.knative.dev/v1/min-event_encoding_structured_version_1.0
    creation.go:85: Failed to create "InMemoryChannel" "min-event-structured-10-ch": conversion webhook for messaging.knative.dev/v1, Kind=InMemoryChannel failed: Post https://eventing-webhook.knative-eventing-mfky5ppxta.svc:443/?timeout=30s: service "eventing-webhook" not found
=== CONT  TestChannelDataPlaneSuccess/InMemoryChannel-messaging.knative.dev/v1/min-event_encoding_structured_version_1.0
    creation.go:85: Failed to create "InMemoryChannel" "min-event-structured-10-ch": conversion webhook for messaging.knative.dev/v1, Kind=InMemoryChannel failed: Post https://eventing-webhook.knative-eventing-mfky5ppxta.svc:443/?timeout=30s: service "eventing-webhook" not found
    creation.go:90: Failed to create "InMemoryChannel" "min-event-structured-10-ch": conversion webhook for messaging.knative.dev/v1, Kind=InMemoryChannel failed: Post https://eventing-webhook.knative-eventing-mfky5ppxta.svc:443/?timeout=30s: service "eventing-webhook" not found

/retest

@nlopezgi
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2020
@nlopezgi
Copy link
Contributor Author

ugh, forgot to fix some single quotes, lets see if tests pass now.

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestBrokerV1Beta1DataPlaneConsumer

@nlopezgi
Copy link
Contributor Author

/test pull-knative-eventing-conformance-tests

@nlopezgi
Copy link
Contributor Author

@lionelvillard this needs a renewed lgtm. Thanks

@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2020
@knative-prow-robot knative-prow-robot merged commit e8307cb into knative:master Aug 14, 2020
@pierDipi pierDipi mentioned this pull request Aug 20, 2020
Closed
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionelvillard lionelvillard lionelvillard left review comments

@mattmoor mattmoor mattmoor left review comments

@pierDipi pierDipi pierDipi approved these changes

@Harwayne Harwayne Awaiting requested review from Harwayne

@lberk lberk Awaiting requested review from lberk

Assignees

@lionelvillard lionelvillard

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nlopezgi @lionelvillard @knative-prow-robot @pierDipi @knative-test-reporter-robot @mattmoor @googlebot