Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl explain for Broker #3848

Merged
merged 1 commit into from
Aug 14, 2020
Merged

kubectl explain for Broker #3848

merged 1 commit into from
Aug 14, 2020

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Aug 14, 2020 •
edited
Loading

Part of #3054

Proposed Changes

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 14, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2020
pierDipi
pierDipi approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2020
@pierDipi
Copy link
Member

/cc @lionelvillard
/retitle "kubectl explain for Broker"

@nlopezgi nlopezgi changed the title [WIP] kubectl explain for Broker kubectl explain for Broker Aug 14, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2020
@nlopezgi
Copy link
Contributor Author

this is now passing and ready to be merged fyi @lionelvillard

@lionelvillard
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, nlopezgi, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2020
@knative-prow-robot knative-prow-robot merged commit 82e15e3 into knative:master Aug 14, 2020
@nlopezgi nlopezgi deleted the issue-3054-7 branch August 14, 2020 19:17
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@lberk lberk Awaiting requested review from lberk

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nlopezgi @pierDipi @lionelvillard @knative-prow-robot @googlebot