Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert change to get PingSource specs from ConfigMaps #3935

Merged

Conversation

lionelvillard
Copy link
Member

Proposed Changes

Release Note


Docs

This PR needs to be backported to 17.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 26, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/mtping/adapter.go 60.9% 62.5% 1.6
pkg/adapter/mtping/controller.go Do not exist 100.0%
pkg/adapter/mtping/pingsource.go Do not exist 72.2%
pkg/reconciler/pingsource/controller.go 92.3% 91.7% -0.6

@cr22rc
Copy link
Contributor

cr22rc commented Aug 26, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@knative-prow-robot knative-prow-robot merged commit ce6bc0d into knative:master Aug 26, 2020
@lionelvillard lionelvillard deleted the revert-pingsource-cm branch September 3, 2020 15:33
@lionelvillard lionelvillard restored the revert-pingsource-cm branch September 3, 2020 15:42
@lionelvillard lionelvillard deleted the revert-pingsource-cm branch September 3, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants